From ac2146118b83ca08aa6dd1275f65eefaed9fe2c0 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 3 Sep 2018 12:26:10 -0300 Subject: [PATCH] use EMPTY_STRING in _parent_via_in_reply_to This is a review suggestion [1] of Tomi. I decided not to squash it so that the code movement remains clear. [1]: id:m2pnxxgf5q.fsf@guru.guru-group.fi --- lib/thread.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/thread.cc b/lib/thread.cc index 62dbd3b3..4711319d 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -402,7 +402,7 @@ _parent_via_in_reply_to (notmuch_thread_t *thread, notmuch_message_t *message) { THREAD_DEBUG("checking message = %s in_reply_to=%s\n", notmuch_message_get_message_id (message), in_reply_to); - if (in_reply_to && strlen (in_reply_to) && + if (in_reply_to && (! EMPTY_STRING(in_reply_to)) && g_hash_table_lookup_extended (thread->message_hash, in_reply_to, NULL, (void **) &parent)) { -- 2.43.0