From d6e3905df7cacb14832cd045280347f36fb0be19 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sat, 24 Nov 2012 23:57:04 -0500 Subject: [PATCH] lib: Eliminate _notmuch_message_list_append This API invited micro-optimized and complicated list pointer manipulation and is no longer used. --- lib/messages.c | 17 +++-------------- lib/notmuch-private.h | 4 ---- 2 files changed, 3 insertions(+), 18 deletions(-) diff --git a/lib/messages.c b/lib/messages.c index 11218648..0eee5690 100644 --- a/lib/messages.c +++ b/lib/messages.c @@ -42,19 +42,7 @@ _notmuch_message_list_create (const void *ctx) return list; } -/* Append a single 'node' to the end of 'list'. - */ -void -_notmuch_message_list_append (notmuch_message_list_t *list, - notmuch_message_node_t *node) -{ - *(list->tail) = node; - list->tail = &node->next; -} - -/* Allocate a new node for 'message' and append it to the end of - * 'list'. - */ +/* Append 'message' to the end of 'list'. */ void _notmuch_message_list_add_message (notmuch_message_list_t *list, notmuch_message_t *message) @@ -64,7 +52,8 @@ _notmuch_message_list_add_message (notmuch_message_list_t *list, node->message = message; node->next = NULL; - _notmuch_message_list_append (list, node); + *(list->tail) = node; + list->tail = &node->next; } notmuch_messages_t * diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h index c054a0e9..f38ccb39 100644 --- a/lib/notmuch-private.h +++ b/lib/notmuch-private.h @@ -428,10 +428,6 @@ struct visible _notmuch_messages { notmuch_message_list_t * _notmuch_message_list_create (const void *ctx); -void -_notmuch_message_list_append (notmuch_message_list_t *list, - notmuch_message_node_t *node); - void _notmuch_message_list_add_message (notmuch_message_list_t *list, notmuch_message_t *message); -- 2.43.0