diff options
| author | David Bremner <david@tethera.net> | 2017-08-27 20:58:23 -0300 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2017-09-05 21:53:06 -0300 |
| commit | 64e30aeb245631e3e30091e426fd45bfc2dcb448 (patch) | |
| tree | f6e381077038374cdb1094086382e17b327fb6b0 | |
| parent | debfae20db9a45ce7e12ac51db2b0104cd3b0be2 (diff) | |
test/duplicate-mid: check for subject with notmuch-show
In [1] Mark showed that the the current code (d7a49e81) is not
consistent in it's handling of subjects of messages with duplicate
message-ids (or in notmuch-speak, of messages with multiple files).
notmuch-search uses indexing order and explicitedly preserves the
first. notmuch-show (apparently) uses alphabetical (or at least xapian
term order) of filenames. In a perfect world we would probably report
all subjects in the json output; at the very least we should be
consistent.
[1]: id:87378dny3d.fsf@qmul.ac.uk
| -rwxr-xr-x | test/T670-duplicate-mid.sh | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/test/T670-duplicate-mid.sh b/test/T670-duplicate-mid.sh index ce010cf7..21a9689a 100755 --- a/test/T670-duplicate-mid.sh +++ b/test/T670-duplicate-mid.sh @@ -13,6 +13,31 @@ EOF notmuch search id:duplicate | notmuch_search_sanitize > OUTPUT test_expect_equal_file EXPECTED OUTPUT +test_begin_subtest 'First subject preserved in notmuch-show (json)' +test_subtest_known_broken +output=$(notmuch show --body=false --format=json id:duplicate | notmuch_json_show_sanitize) +expected='[[[{ + "id": "XXXXX", + "match": true, + "excluded": false, + "filename": [ + "'"${MAIL_DIR}"/copy0'", + "'"${MAIL_DIR}"/copy1'", + "'"${MAIL_DIR}"/copy2'" + ], + "timestamp": 42, + "date_relative": "2001-01-05", + "tags": ["inbox","unread"], + "headers": { + "Subject": "message 1", + "From": "Notmuch Test Suite <test_suite@notmuchmail.org>", + "To": "Notmuch Test Suite <test_suite@notmuchmail.org>", + "Date": "GENERATED_DATE" + } + }, +[]]]]' +test_expect_equal_json "$output" "$expected" + test_begin_subtest 'Search for second subject' cat <<EOF >EXPECTED MAIL_DIR/copy0 |