aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomi Ollila <tomi.ollila@iki.fi>2015-02-18 16:54:01 +0200
committerDavid Bremner <david@tethera.net>2015-02-19 19:14:29 +0100
commit91ef2ae52421c3e20a903109bfca3d87d7c2e61d (patch)
tree23266913b3f175e7f824b3463fa07cb39ef1f06f
parent1722ea2c95865cb20cc2578894eca2cdaddc1d7a (diff)
configure: consistent command -v usage
When the shell builtin `command -v` operates normally, it either prints the path of the arg given to it and returns zero -- or it returns nonzero and prints nothing. In abnormal situations something might be printed to stderr and in that case we want to know about it; therefore the used command -v stderr redirections to /dev/null have been removed. The `hash` (builtin) command in ksh returns zero even the arg given to is is not found in path. For that and for consistency the one appearance of it has been converted to `command -v`.
-rwxr-xr-xconfigure6
1 files changed, 3 insertions, 3 deletions
diff --git a/configure b/configure
index a6b49ae4..4af7ba94 100755
--- a/configure
+++ b/configure
@@ -378,7 +378,7 @@ printf "Checking for python... "
have_python=0
for name in python python2 python3; do
- if command -v $name > /dev/null 2>&1; then
+ if command -v $name > /dev/null; then
have_python=1
python=$name
printf "Yes ($name).\n"
@@ -435,7 +435,7 @@ else
fi
printf "Checking if doxygen is available... "
-if command -v doxygen > /dev/null 2>&1; then
+if command -v doxygen > /dev/null; then
printf "Yes.\n"
have_doxygen=1
else
@@ -444,7 +444,7 @@ else
fi
printf "Checking if sphinx is available and supports nroff output... "
-if hash sphinx-build > /dev/null 2>&1 && ${python} -m sphinx.writers.manpage > /dev/null 2>&1 ; then
+if command -v sphinx-build > /dev/null && ${python} -m sphinx.writers.manpage > /dev/null 2>&1 ; then
printf "Yes.\n"
have_sphinx=1
else