diff options
| author | Jonas Bernoulli <jonas@bernoul.li> | 2021-01-10 15:00:48 +0100 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2021-01-13 07:16:23 -0400 |
| commit | 0067a43ea2ee554eafed1e1300a71259cd6b6a6d (patch) | |
| tree | 3434a63a6df67c7da6073ce2c25e2071b28aab9a /emacs/notmuch-hello.el | |
| parent | fc4cda07a9afbbb545dcc6cd835ca697f6ef2a1b (diff) | |
emacs: deal with unused lexical arguments and variables
The previous commit switched to lexical-binding but without dealing
with the new warnings about unused lexical arguments and variables.
This commit deals with most of them, in most cases by either removing
leftover bindings that are actually unnecessary, or by marking certain
arguments as "known to be unused" by prefixing their names with "_".
In the case of the functions named `notmuch-show-insert-...' the
amount of silencing that is required is a bit extreme and we might
want to investigate if there is a better way.
In the case of `notmuch-mua-mail', ignoring CONTINUE means that we do
not fully follow the intended behavior described in `compose-mail's
doc-string.
Diffstat (limited to 'emacs/notmuch-hello.el')
| -rw-r--r-- | emacs/notmuch-hello.el | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 586a2848..a134eb07 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -480,7 +480,7 @@ diagonal." (cl-loop for row from 0 to (- nrows 1) append (notmuch-hello-reflect-generate-row ncols nrows row list)))) -(defun notmuch-hello-widget-search (widget &rest ignore) +(defun notmuch-hello-widget-search (widget &rest _ignore) (cond ((eq (widget-get widget :notmuch-search-type) 'tree) (notmuch-tree (widget-get widget @@ -775,14 +775,14 @@ Complete list of currently available key bindings: (let ((widget-link-prefix "") (widget-link-suffix "")) (widget-create 'link - :notify (lambda (&rest ignore) + :notify (lambda (&rest _ignore) (browse-url notmuch-hello-url)) :help-echo "Visit the notmuch website." "notmuch") (widget-insert ". ") (widget-insert "You have ") (widget-create 'link - :notify (lambda (&rest ignore) + :notify (lambda (&rest _ignore) (notmuch-hello-update)) :help-echo "Refresh" (notmuch-hello-nice-number @@ -801,7 +801,7 @@ Complete list of currently available key bindings: (when searches (widget-insert "Saved searches: ") (widget-create 'push-button - :notify (lambda (&rest ignore) + :notify (lambda (&rest _ignore) (customize-variable 'notmuch-saved-searches)) "edit") (widget-insert "\n\n") @@ -873,13 +873,13 @@ Supports the following entries in OPTIONS as a plist: (start (point))) (if is-hidden (widget-create 'push-button - :notify `(lambda (widget &rest ignore) + :notify `(lambda (widget &rest _ignore) (setq notmuch-hello-hidden-sections (delete ,title notmuch-hello-hidden-sections)) (notmuch-hello-update)) "show") (widget-create 'push-button - :notify `(lambda (widget &rest ignore) + :notify `(lambda (widget &rest _ignore) (add-to-list 'notmuch-hello-hidden-sections ,title) (notmuch-hello-update)) @@ -928,13 +928,13 @@ following: (widget-insert "Hit `?' for context-sensitive help in any Notmuch screen.\n") (widget-insert "Customize ") (widget-create 'link - :notify (lambda (&rest ignore) + :notify (lambda (&rest _ignore) (customize-group 'notmuch)) :button-prefix "" :button-suffix "" "Notmuch") (widget-insert " or ") (widget-create 'link - :notify (lambda (&rest ignore) + :notify (lambda (&rest _ignore) (customize-variable 'notmuch-hello-sections)) :button-prefix "" :button-suffix "" "this page.") |