diff options
| author | Jonas Bernoulli <jonas@bernoul.li> | 2020-08-08 13:49:40 +0200 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2020-08-09 20:50:50 -0300 |
| commit | 18d289c86309ae796e6f027c289b17ccdd38f220 (patch) | |
| tree | 7e65002334f277b907f838c30ddcd0f5a3b2742b /emacs/notmuch-lib.el | |
| parent | 2ee8e971c546f0ffed726099b844cbd5f05de029 (diff) | |
emacs: Only set one variable per setq form
It's a bit weird to avoid having to write the "(setq ... )" more than
once, just because we can. In a language that uses '=' for the same
purpose we also happily use that once per assignment.
While there are no benefit to using just one 'setq' there are some
drawbacks. It is not always clear on first what is a key and what a
value and as a result it is easy to make a mistake. Also it becomes
harder to comment out just one assignment.
Diffstat (limited to 'emacs/notmuch-lib.el')
| -rw-r--r-- | emacs/notmuch-lib.el | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index f8958a91..886da99f 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -861,8 +861,8 @@ for `call-process'. ARGS is as described for (let (stdin-string) (while (keywordp (car args)) (cl-case (car args) - (:stdin-string (setq stdin-string (cadr args) - args (cddr args))) + (:stdin-string (setq stdin-string (cadr args)) + (setq args (cddr args))) (otherwise (error "Unknown keyword argument: %s" (car args))))) (if (null stdin-string) @@ -939,8 +939,8 @@ status." :buffer buffer :command (cons command args) :connection-type 'pipe - :stderr err-buffer) - err-proc (get-buffer-process err-buffer)) + :stderr err-buffer)) + (setq err-proc (get-buffer-process err-buffer)) (process-put proc 'err-buffer err-buffer) (process-put err-proc 'err-file err-file) |