aboutsummaryrefslogtreecommitdiff
path: root/emacs/notmuch.el
diff options
context:
space:
mode:
authorJonas Bernoulli <jonas@bernoul.li>2021-01-10 15:01:03 +0100
committerDavid Bremner <david@tethera.net>2021-01-15 06:44:01 -0400
commit42d32713be9a23346de09b84983e1dd3b44b3400 (patch)
treed3aa2c1a8abde14d54265c04513e393c8b0e1b1b /emacs/notmuch.el
parentb614ea756316a18d90f5acfa352e82f2ffec8a67 (diff)
emacs: define a few variables as automatically buffer-local
Define these variables as automatically buffer-local, meaning that they always become buffer-local when set unless explicitly told otherwise using `setq-default' or when using the Custom interface. Previously they were declared, which keeps the byte-compiler quiet but is not actually the same as being defined. `notmuch-search-mode' then made them buffer-local in the current buffer and then set the local values. This works but is not kosher. The definitions of the three non-option variables have to be moved up a bit to enable the change in the next commit, which see.
Diffstat (limited to 'emacs/notmuch.el')
-rw-r--r--emacs/notmuch.el16
1 files changed, 6 insertions, 10 deletions
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index ccece811..027c5cfa 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -205,6 +205,12 @@ there will be called at other points of notmuch execution."
map)
"Keymap for \"notmuch search\" buffers.")
+;;; Internal Variables
+
+(defvar-local notmuch-search-query-string nil)
+(defvar-local notmuch-search-target-thread nil)
+(defvar-local notmuch-search-target-line nil)
+
;;; Stashing
(defvar notmuch-search-stash-map
@@ -226,12 +232,6 @@ there will be called at other points of notmuch execution."
(interactive)
(notmuch-common-do-stash (notmuch-search-get-query)))
-;;; Variables
-
-(defvar notmuch-search-query-string)
-(defvar notmuch-search-target-thread)
-(defvar notmuch-search-target-line)
-
;;; Movement
(defun notmuch-search-scroll-up ()
@@ -404,10 +404,6 @@ new, global search.
Complete list of currently available key bindings:
\\{notmuch-search-mode-map}"
- (make-local-variable 'notmuch-search-query-string)
- (make-local-variable 'notmuch-search-oldest-first)
- (make-local-variable 'notmuch-search-target-thread)
- (make-local-variable 'notmuch-search-target-line)
(setq notmuch-buffer-refresh-function #'notmuch-search-refresh-view)
(setq-local scroll-preserve-screen-position t)
(add-to-invisibility-spec (cons 'ellipsis t))