diff options
| author | Daniel Kahn Gillmor <dkg@fifthhorseman.net> | 2021-05-26 21:44:58 -0400 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2021-06-26 13:07:47 -0300 |
| commit | 8c29a5da096b0314c6cca8889b740b79a9a548ed (patch) | |
| tree | 4e967955f6f29c0b74d949fc90e18f8dc4a27ab4 /notmuch-show.c | |
| parent | 4b0c6fb2f1ba989fee554cb8fa2612046d6414a8 (diff) | |
cli/show: produce "email" element in sigstatus
When the certificate that signs a message is known to be valid, GMime
is capable of reporting on the e-mail address embedded in the
certificate.
We pass this information along to the caller of "notmuch show", as
often only the e-mail address of the certificate has actually been
checked/verified.
Furthermore, signature verification should probably at some point
compare the e-mail address of the caller against the sender address of
the message itself. Having to parse what gmime thinks is a "userid"
to extract an e-mail address seems clunky and unnecessary if gmime
already thinks it knows what the e-mail address is.
See id:878s41ax6t.fsf@fifthhorseman.net for more motivation and discussion.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Diffstat (limited to 'notmuch-show.c')
| -rw-r--r-- | notmuch-show.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/notmuch-show.c b/notmuch-show.c index bdb87321..232557d5 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -475,6 +475,11 @@ format_part_sigstatus_sprinter (sprinter_t *sp, GMimeSignatureList *siglist) sp->map_key (sp, "userid"); sp->string (sp, uid); } + const char *email = g_mime_certificate_get_valid_email (certificate); + if (email) { + sp->map_key (sp, "email"); + sp->string (sp, email); + } } } else if (certificate) { const char *key_id = g_mime_certificate_get_fpr16 (certificate); |