diff options
| author | David Bremner <david@tethera.net> | 2021-05-17 23:06:01 -0300 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2021-06-27 14:03:00 -0300 |
| commit | e2a3e5fa51122efb0f5ac836e536881d97deef1a (patch) | |
| tree | 1445b342be81e30408f9690698f237c3dd06a1fd /test/T385-transactions.sh | |
| parent | 8aabddb043d6bf5bd8a19884b3c456ba9d4634cb (diff) | |
lib: autocommit after some number of completed transactions
This change addresses two known issues with large sets of changes to
the database. The first is that as reported by Steven Allen [1],
notmuch commits are not "flushed" when they complete, which means that
if there is an open transaction when the database closes (or e.g. the
program crashes) then all changes since the last commit will be
discarded (nothing is irrecoverably lost for "notmuch new", as the
indexing process just restarts next time it is run). This does not
really "fix" the issue reported in [1]; that seems rather difficult
given how transactions work in Xapian. On the other hand, with the
default settings, this should mean one only loses less than a minutes
worth of work. The second issue is the occasionally reported "storm"
of disk writes when notmuch finishes. I don't yet have a test for
this, but I think committing as we go should reduce the amount of work
when finalizing the database.
[1]: id:20151025210215.GA3754@stebalien.com
Diffstat (limited to 'test/T385-transactions.sh')
| -rwxr-xr-x | test/T385-transactions.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/T385-transactions.sh b/test/T385-transactions.sh index ebfec2ed..d8bb502d 100755 --- a/test/T385-transactions.sh +++ b/test/T385-transactions.sh @@ -26,7 +26,6 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "Some changes saved with open transaction" -test_subtest_known_broken notmuch config set database.autocommit 1000 rm -r ${MAIL_DIR}/.notmuch notmuch_with_shim no-close new |