diff options
| author | David Bremner <david@tethera.net> | 2021-10-30 13:22:35 -0300 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2021-12-04 08:42:31 -0400 |
| commit | d7f95724132bf658fd151630185899737e2ed829 (patch) | |
| tree | b2de6db9dcc0cc369206a885e311e8d506ad043d /test/T391-python-cffi.sh | |
| parent | caafab01a4409fd2a1a5d31b3d05815bf587d8e0 (diff) | |
python-cffi: switch to notmuch_database_{open,create}_with_config
Since release 0.32, libnotmuch provides searching for database and
configuration paths. This commit changes the python module notmuch2 to
use those facilities.
This fixes the bug reported in [1], along with a couple of the
deprecation warnings in the python bindings.
Database.default_path is deprecated, since it no longer faithfully
reflects what libnotmuch is doing, and it is also no longer used in
the bindings themselves.
This commit choose the default of config=CONFIG.EMPTY (equivalent to
passing "" to notmuch_database_open_with_config). This makes the
change upward compatible API-wise (at least as far as the test suite
verifies), but changing the default to CONFIG.SEARCH would probably be
more convenient for bindings users.
[1]: id:87h7d4wp6b.fsf@tethera.net
Diffstat (limited to 'test/T391-python-cffi.sh')
| -rwxr-xr-x | test/T391-python-cffi.sh | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/test/T391-python-cffi.sh b/test/T391-python-cffi.sh index d54bad27..30872af0 100755 --- a/test/T391-python-cffi.sh +++ b/test/T391-python-cffi.sh @@ -7,8 +7,14 @@ if [ $NOTMUCH_HAVE_PYTHON3_CFFI -eq 0 -o $NOTMUCH_HAVE_PYTHON3_PYTEST -eq 0 ]; t fi -test_begin_subtest "python cffi tests" +test_begin_subtest "python cffi tests (NOTMUCH_CONFIG set)" pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --verbose --log-file=$TMP_DIRECTORY/test.output)" + +test_begin_subtest "python cffi tests (NOTMUCH_CONFIG unset)" +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage +printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini +unset NOTMUCH_CONFIG +test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --verbose --log-file=$TMP_DIRECTORY/test.output)" test_done |