diff options
| author | David Bremner <david@tethera.net> | 2021-10-23 10:22:36 -0300 |
|---|---|---|
| committer | David Bremner <david@tethera.net> | 2021-10-30 13:47:47 -0300 |
| commit | 2ba50b52302dce08068843e0029f9ee935a0d7f3 (patch) | |
| tree | d52b8595858c0575e4aabe89f113de37b7e30f24 /test/T590-libconfig.sh | |
| parent | f3fcdd2ddac2384c0c1daeffa495ad3ec01bc1af (diff) | |
lib/create: fix memory leak, ensure *database=NULL on error
This code previously relied on _finish_open to free the notmuch struct
on errors (except for the case of database == NULL, which was a
potential double free). When we removed those frees from _finish_open,
we introduced a (small) memory leak.
In this commit, fix the memory leak, and harmonize the on-error
behaviour with n_d_open_with_config.
Diffstat (limited to 'test/T590-libconfig.sh')
| -rwxr-xr-x | test/T590-libconfig.sh | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/test/T590-libconfig.sh b/test/T590-libconfig.sh index adb9b6e7..bed887aa 100755 --- a/test/T590-libconfig.sh +++ b/test/T590-libconfig.sh @@ -891,7 +891,6 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "create: database set to null on missing config" -test_subtest_known_broken cat c_head3 - c_tail3 <<'EOF' | test_C ${MAIL_DIR} "/nonexistent" notmuch_status_t st = notmuch_database_create_with_config(argv[1],argv[2], NULL, &db, NULL); EOF @@ -903,7 +902,6 @@ EOF test_expect_equal_file EXPECTED OUTPUT test_begin_subtest "create: database set to null on missing config (env)" -test_subtest_known_broken old_NOTMUCH_CONFIG=${NOTMUCH_CONFIG} NOTMUCH_CONFIG="/nonexistent" cat c_head3 - c_tail3 <<'EOF' | test_C ${MAIL_DIR} |