aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorAustin Clements <amdragon@mit.edu>2014-10-23 08:30:37 -0400
committerDavid Bremner <david@tethera.net>2014-10-25 19:27:07 +0200
commit58a4277d3b2ad88bc285f2dae998626b0aa73299 (patch)
tree7fc290519ff484008c2c4c8cc36f636edd9b5c53 /test
parentbc9c50602d20ce712188ea2cc3c5d30647d4d3f5 (diff)
lib: Implement ghost-based thread linking
This updates the thread linking code to use ghost messages instead of user metadata to link messages into threads. In contrast with the old approach, this is actually correct. Previously, thread merging updated only the thread IDs of message documents, not thread IDs stored in user metadata. As originally diagnosed by Mark Walters [1] and as demonstrated by the broken T260-thread-order test, this can cause notmuch to fail to link messages even though they're in the same thread. In principle the old approach could have been fixed by updating the user metadata thread IDs as well, but these are not indexed and hence this would have required a full scan of all stored thread IDs. Ghost messages solve this problem naturally by reusing the exact same thread ID and message ID representation and indexing as regular messages. Furthermore, thanks to this greater symmetry, ghost messages are also algorithmically simpler. We continue to support the old user metadata format, so this patch can't delete any code, but when we do remove support for the old format, several functions can simply be deleted. [1] id:8738h7kv2q.fsf@qmul.ac.uk
Diffstat (limited to 'test')
0 files changed, 0 insertions, 0 deletions