1 From: David Howells <dhowells@redhat.com>
2 Subject: Re: [RFC][PATCH 04/10] cifs: define server-level cache index objects and register them with FS-Cache
3 Date: Wed, 23 Jun 2010 17:54:52 +0100
4 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
5 Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
7 Registered in England and Wales under Company Registration No. 3798903
9 Message-ID: <9658.1277312092@redhat.com>
10 References: <1277220198-3522-1-git-send-email-sjayaraman@suse.de> <yes>
11 Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
12 linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
13 linux-kernel@vger.kernel.org
14 To: Suresh Jayaraman <sjayaraman@suse.de>
15 X-From: linux-fsdevel-owner@vger.kernel.org Wed Jun 23 18:55:07 2010
16 Return-path: <linux-fsdevel-owner@vger.kernel.org>
17 Envelope-to: lnx-linux-fsdevel@lo.gmane.org
18 Received: from vger.kernel.org ([209.132.180.67])
19 by lo.gmane.org with esmtp (Exim 4.69)
20 (envelope-from <linux-fsdevel-owner@vger.kernel.org>)
22 for lnx-linux-fsdevel@lo.gmane.org; Wed, 23 Jun 2010 18:55:05 +0200
23 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
24 id S1752263Ab0FWQzD (ORCPT <rfc822;lnx-linux-fsdevel@m.gmane.org>);
25 Wed, 23 Jun 2010 12:55:03 -0400
26 Received: from mx1.redhat.com ([209.132.183.28]:18394 "EHLO mx1.redhat.com"
27 rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
28 id S1751794Ab0FWQzB (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
29 Wed, 23 Jun 2010 12:55:01 -0400
30 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
31 by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5NGsu1L000993
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
33 Wed, 23 Jun 2010 12:54:56 -0400
34 Received: from redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])
35 by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5NGsrUG016433;
36 Wed, 23 Jun 2010 12:54:54 -0400
37 In-Reply-To: <1277220198-3522-1-git-send-email-sjayaraman@suse.de>
38 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17
39 Sender: linux-fsdevel-owner@vger.kernel.org
41 List-ID: <linux-fsdevel.vger.kernel.org>
42 X-Mailing-List: linux-fsdevel@vger.kernel.org
43 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002221>
45 Suresh Jayaraman <sjayaraman@suse.de> wrote:
47 > Define server-level cache index objects (as managed by TCP_ServerInfo
48 > structs). Each server object is created in the CIFS top-level index object
49 > and is itself an index into which superblock-level objects are inserted.
51 > Currently, the server objects are keyed by hostname.
53 > Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
55 Looks reasonable, apart from the index key. I agree with Jeff that you
56 probably want {address,port,family} rather than a hostname.
60 To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
61 the body of a message to majordomo@vger.kernel.org
62 More majordomo info at http://vger.kernel.org/majordomo-info.html