1 From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
2 Subject: Re: [RFC][PATCH 10/10] cifs: add mount option to enable local caching
3 Date: Fri, 25 Jun 2010 16:18:12 +0530
5 Message-ID: <4C24896C.4000903@suse.de>
6 References: <yes> <1277220309-3757-1-git-send-email-sjayaraman@suse.de> <4C225338.9010807@gmail.com>
8 Content-Type: text/plain; charset=UTF-8
9 Content-Transfer-Encoding: 7bit
10 Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
11 linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
12 David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
13 To: Scott Lovenberg <scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
14 X-From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Fri Jun 25 12:48:27 2010
15 Return-path: <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
16 Envelope-to: glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org
17 Received: from vger.kernel.org ([209.132.180.67])
18 by lo.gmane.org with esmtp (Exim 4.69)
19 (envelope-from <linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>)
21 for glkc-linux-cifs-1dZseelyfdZg9hUCZPvPmw@public.gmane.org; Fri, 25 Jun 2010 12:48:25 +0200
22 Received: (majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org) by vger.kernel.org via listexpand
23 id S1753965Ab0FYKsX (ORCPT <rfc822;glkc-linux-cifs@m.gmane.org>);
24 Fri, 25 Jun 2010 06:48:23 -0400
25 Received: from cantor.suse.de ([195.135.220.2]:46395 "EHLO mx1.suse.de"
26 rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
27 id S1752612Ab0FYKsW (ORCPT <rfc822;linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>);
28 Fri, 25 Jun 2010 06:48:22 -0400
29 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2])
30 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
31 (No client certificate requested)
32 by mx1.suse.de (Postfix) with ESMTP id 60CED6CB00;
33 Fri, 25 Jun 2010 12:48:21 +0200 (CEST)
34 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0
35 In-Reply-To: <4C225338.9010807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
36 Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
38 List-ID: <linux-cifs.vger.kernel.org>
39 X-Mailing-List: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
40 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1002912>
42 On 06/24/2010 12:02 AM, Scott Lovenberg wrote:
43 > On 6/22/2010 11:25 AM, Suresh Jayaraman wrote:
44 >> Add a mount option 'fsc' to enable local caching on CIFS.
46 >> As the cifs-utils (userspace) changes are not done yet, this patch
48 >> 'fsc' by default to assist testing.
51 >> @@ -1332,6 +1336,8 @@ cifs_parse_mount_options(char *options, const
53 >> printk(KERN_WARNING "CIFS: Mount option noac not "
54 >> "supported. Instead set "
55 >> "/proc/fs/cifs/LookupCacheEnabled to 0\n");
56 >> + } else if (strnicmp(data, "fsc", 3) == 0) {
59 >> printk(KERN_WARNING "CIFS: Unknown mount option %s\n",
61 >> @@ -2405,6 +2411,8 @@ static void setup_cifs_sb(struct smb_vol
63 >> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_OVERR_GID;
64 >> if (pvolume_info->dynperm)
65 >> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DYNPERM;
66 >> + if (pvolume_info->fsc)
67 >> + cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_FSCACHE;
68 >> if (pvolume_info->direct_io) {
69 >> cFYI(1, "mounting share using direct i/o");
70 >> cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DIRECT_IO;
72 > I reworked the CIFS mount option parsing a while back; I'm not sure
73 > whether that patch was going to be in the 2.6.35 tree or not (the window
74 > just opened, didn't it?).
76 Not a problem, I could redo this patch alone when the reworked option
77 parsing patches get in.
79 > Jeff, Steve, can you confirm if that patch is going to be in 2.6.35?
81 > Patch refs: http://patchwork.ozlabs.org/patch/53059/ and
82 > http://patchwork.ozlabs.org/patch/53674/