1 From: "Bounine, Alexandre" <Alexandre.Bounine@idt.com>
2 Subject: RE: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port
3 Date: Thu, 5 Aug 2010 10:25:18 -0700
5 Message-ID: <0CE8B6BE3C4AD74AB97D9D29BD24E552011935BD@CORPEXCH1.na.ads.idt.com>
6 References: <20100308191005.GE4324@amak.tundra.com>
7 <AANLkTine3pc2Ai2Woj81Y9fS_KgGs1sIMb2NMR6G74ww@mail.gmail.com>
8 <AANLkTinKbimKyLpvFD7KOvavshu_n8gRcp2BvEJj0XZQ@mail.gmail.com>
9 <4381.1280815590@neuling.org>
10 <0CE8B6BE3C4AD74AB97D9D29BD24E5520114309D@CORPEXCH1.na.ads.idt.com>
11 <AANLkTinpwYnyc1oN1VbtBgUF6bk6E5q_Gq1Dj3WXV3wc@mail.gmail.com>
12 <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC@CORPEXCH1.na.ads.idt.com>
13 <26581.1280979260@neuling.org>
15 Content-Type: text/plain; charset="us-ascii"
16 Content-Transfer-Encoding: 7bit
17 Cc: Li Yang-R58472 <r58472@freescale.com>, linux-kernel@vger.kernel.org,
18 Alexandre Bounine <abounine@tundra.com>, thomas.moll@sysgo.com,
19 linuxppc-dev@lists.ozlabs.org, Timur Tabi <timur@freescale.com>
20 To: "Michael Neuling" <mikey@neuling.org>
21 X-From: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Thu Aug 05 19:25:54 2010
22 Return-path: <linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org>
23 Envelope-to: glppe-linuxppc-embedded-2@m.gmane.org
24 Received: from ozlabs.org ([203.10.76.45])
25 by lo.gmane.org with esmtp (Exim 4.69)
26 (envelope-from <linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org>)
28 for glppe-linuxppc-embedded-2@m.gmane.org; Thu, 05 Aug 2010 19:25:54 +0200
29 Received: from bilbo.ozlabs.org (localhost [127.0.0.1])
30 by ozlabs.org (Postfix) with ESMTP id ED044100873
31 for <glppe-linuxppc-embedded-2@m.gmane.org>; Fri, 6 Aug 2010 03:25:45 +1000 (EST)
32 Received: from mxout1.idt.com (mxout1.idt.com [157.165.5.25])
33 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
34 (Client CN "mxout1.idt.com", Issuer "idt.com" (not verified))
35 by ozlabs.org (Postfix) with ESMTPS id 43F72B6EEA
36 for <linuxppc-dev@lists.ozlabs.org>;
37 Fri, 6 Aug 2010 03:25:34 +1000 (EST)
38 Received: from mail.idt.com (localhost [127.0.0.1])
39 by mxout1.idt.com (8.13.1/8.13.1) with ESMTP id o75HPQdX013269;
40 Thu, 5 Aug 2010 10:25:26 -0700
41 Received: from corpml1.corp.idt.com (corpml1.corp.idt.com [157.165.140.20])
42 by mail.idt.com (8.13.8/8.13.8) with ESMTP id o75HPMOi016437;
43 Thu, 5 Aug 2010 10:25:23 -0700 (PDT)
44 Received: from CORPEXCH1.na.ads.idt.com (localhost [127.0.0.1])
45 by corpml1.corp.idt.com (8.11.7p1+Sun/8.11.7) with ESMTP id
46 o75HPKp19185; Thu, 5 Aug 2010 10:25:21 -0700 (PDT)
47 X-MimeOLE: Produced By Microsoft Exchange V6.5
48 Content-class: urn:content-classes:message
49 In-Reply-To: <26581.1280979260@neuling.org>
52 Thread-Topic: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port
53 Thread-Index: Acs0TsVj0+lZKwxtSsOT8qDn1XxpJAAdBmhA
54 X-Scanned-By: MIMEDefang 2.43
55 X-BeenThere: linuxppc-dev@lists.ozlabs.org
56 X-Mailman-Version: 2.1.13
58 List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
59 List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
60 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
61 List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
62 List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
63 List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
64 List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
65 <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
66 Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org
67 Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org
68 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1019383>
70 Below is a copy of Leo's message with pointers to the patches.
74 >Subject: [PATCH] RapidIO,powerpc/85xx: remove MCSR_MASK in fsl_rio
76 >Fixes compile problem caused by MCSR_MASK removal from book-E
81 Only with your patch, there will still be problem on SRIO platforms
84 I have posted a patch series to fix this together with several
85 compatibility issues a month before.
87 http://patchwork.ozlabs.org/patch/56135/
88 http://patchwork.ozlabs.org/patch/56136/
89 http://patchwork.ozlabs.org/patch/56138/
90 http://patchwork.ozlabs.org/patch/56137/
93 Can anyone pick the patch series quickly as currently there is a compile
94 error when SRIO is enabled.
99 > -----Original Message-----
100 > From: Michael Neuling [mailto:mikey@neuling.org]
101 > Sent: Wednesday, August 04, 2010 11:34 PM
102 > To: Bounine, Alexandre
103 > Cc: Timur Tabi; Alexandre Bounine; linuxppc-dev@lists.ozlabs.org;
104 linux-kernel@vger.kernel.org;
105 > thomas.moll@sysgo.com; Kumar Gala
106 > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO
112 <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC@CORPEXCH1.na.ads.idt.com> you
114 > > Yang Li pointed to these patches in his post from July 23, 2010.
115 > > It would be nice to have these patches in mainline code.=20
117 > This is still broken in Kumar's latest tree. Do you guys wanna repost
118 > them so Kumar can pick them up easily?
123 > > > -----Original Message-----
124 > > > From: timur.tabi@gmail.com [mailto:timur.tabi@gmail.com] On Behalf
127 > > > Sent: Tuesday, August 03, 2010 9:02 AM
128 > > > To: Bounine, Alexandre
129 > > > Cc: Michael Neuling; Alexandre Bounine;
130 linuxppc-dev@lists.ozlabs.org;
131 > > linux-kernel@vger.kernel.org;
132 > > > thomas.moll@sysgo.com; Kumar Gala
133 > > > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for
137 > > > On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre
138 > > > <Alexandre.Bounine@idt.com> wrote:
139 > > > > This happened after change to book-e definitions.
140 > > > > There are patches that address this issue.
142 > > > And those patches should have been applied before 2.6.35 was
144 > > > Someone dropped the ball. 2.6.35 is broken for a number of
148 > > > $ make mpc85xx_defconfig
152 > > > CC arch/powerpc/sysdev/fsl_rio.o
153 > > > arch/powerpc/sysdev/fsl_rio.c: In function
154 'fsl_rio_mcheck_exception':
155 > > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared
156 > > > (first use in this function)
157 > > > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared
159 > > > is reported only once
160 > > > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it
163 > > > make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1
167 > > > Linux kernel developer at Freescale