1 From: Joe Perches <joe@perches.com>
2 Subject: Re: [PATCH 44/44] sound/soc/codecs: Remove unnecessary semicolons
3 Date: Mon, 15 Nov 2010 11:52:53 -0800
5 Message-ID: <1289850773.16461.166.camel@Joe-Laptop>
6 References: <cover.1289789604.git.joe@perches.com>
7 <97fd199b7dac50613f6843156687223928cce44a.1289789605.git.joe@perches.com>
8 <20101115134939.GC12986@rakim.wolfsonmicro.main>
9 <1289840957.16461.138.camel@Joe-Laptop>
10 <20101115173031.GI12986@rakim.wolfsonmicro.main>
11 <1289842444.16461.140.camel@Joe-Laptop>
12 <20101115182708.GJ12986@rakim.wolfsonmicro.main>
13 <1289845830.16461.149.camel@Joe-Laptop>
14 <20101115190738.GF3338@sirena.org.uk>
15 <1289848458.16461.150.camel@Joe-Laptop>
16 <20101115193407.GK12986@rakim.wolfsonmicro.main>
18 Content-Type: text/plain; charset="UTF-8"
19 Content-Transfer-Encoding: 7bit
20 Cc: Jiri Kosina <trivial@kernel.org>,
21 Ian Lartey <ian@opensource.wolfsonmicro.com>,
22 Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
23 Liam Girdwood <lrg@slimlogic.co.uk>,
24 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
25 alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
26 To: Mark Brown <broonie@opensource.wolfsonmicro.com>
27 X-From: linux-kernel-owner@vger.kernel.org Mon Nov 15 20:53:21 2010
28 Return-path: <linux-kernel-owner@vger.kernel.org>
29 Envelope-to: glk-linux-kernel-3@lo.gmane.org
30 Received: from vger.kernel.org ([209.132.180.67])
31 by lo.gmane.org with esmtp (Exim 4.69)
32 (envelope-from <linux-kernel-owner@vger.kernel.org>)
34 for glk-linux-kernel-3@lo.gmane.org; Mon, 15 Nov 2010 20:53:20 +0100
35 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
36 id S932871Ab0KOTw5 (ORCPT <rfc822;glk-linux-kernel-3@m.gmane.org>);
37 Mon, 15 Nov 2010 14:52:57 -0500
38 Received: from mail.perches.com ([173.55.12.10]:1328 "EHLO mail.perches.com"
39 rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
40 id S1758222Ab0KOTw4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
41 Mon, 15 Nov 2010 14:52:56 -0500
42 Received: from [192.168.1.162] (unknown [192.168.1.162])
43 by mail.perches.com (Postfix) with ESMTP id CE13524368;
44 Mon, 15 Nov 2010 11:51:05 -0800 (PST)
45 In-Reply-To: <20101115193407.GK12986@rakim.wolfsonmicro.main>
46 X-Mailer: Evolution 2.30.3
47 Sender: linux-kernel-owner@vger.kernel.org
49 List-ID: <linux-kernel.vger.kernel.org>
50 X-Mailing-List: linux-kernel@vger.kernel.org
51 Archived-At: <http://permalink.gmane.org/gmane.linux.kernel/1062724>
53 On Mon, 2010-11-15 at 19:34 +0000, Mark Brown wrote:
54 > On Mon, Nov 15, 2010 at 11:14:18AM -0800, Joe Perches wrote:
55 > > On Mon, 2010-11-15 at 19:07 +0000, Mark Brown wrote:
56 > > > I'd suggest using pattern matching to look up the
57 > > > rules for generating the prefixes (it's pretty much entirely prefixes)
58 > > > in the same way you're handling figuring out who to mail - that'd
59 > > > probably cover it in an automatable fashion.
60 > > Publish a tool that works and I'll use it.
61 > It appears your scripts are already hooked into get_maintainers.pl which
62 > would seem the obvious place to do this? Sadly I don't do perl, though
63 > it looks like you're doing pretty much all the work on that anyway.
65 Sadly, no it's not the right place.
67 That script just generates cc email addresses
68 for pre-formatted commit patches.
70 It'd have to be a script that modifies the git commit subject line
71 to the taste of the subsystem maintainer.
73 Right now, I use a commit script that's something like:
76 echo "$1: Remove unnecessary semicolons" > msg
79 #Unnecessary semicolons should not exist.
81 git commit -s -F msg $1
83 There could be a modification to $1 (path)
87 ./scripts/convert_commit_subject_to_subsystem_maintainer_taste
90 Care to write one in sh/bash/perl/python/c/ocaml/c#?
92 As far as I know, the only subsystem pedants^H^H^H^H^Hople
93 that care much about the commit subject style are
96 I can understand the desire of these subsystem maintainers
97 to have a consistent style. I think though that requiring
98 a subject header style without providing more than a
99 general guideline is a but much.
101 I'd use any other automated tool you want to provide.