test: Adding non-maildir tags does not move message from new to cur

[notmuch] / notmuch-config.c

diff --git a/notmuch-config.c b/notmuch-config.c
index 48312e3f913dda58151efbe591415f875751bb05..6845e3c3db5d3af6f5a9d25f39d4eb8060a1e41a 100644 (file)
--- a/notmuch-config.c
+++ b/notmuch-config.c
@@ -395,39 +395,28 @@ notmuch_config_open (void *ctx,
      * the configuration file, we add some comments to help the user
      * understand what can be done. */
     if (config->is_new)
-    {
        g_key_file_set_comment (config->key_file, NULL, NULL,
                                toplevel_config_comment, NULL);
-    }
 
     if (! file_had_database_group)
-    {
        g_key_file_set_comment (config->key_file, "database", NULL,
                                database_config_comment, NULL);
-    }
 
     if (! file_had_new_group)
-    {
        g_key_file_set_comment (config->key_file, "new", NULL,
                                new_config_comment, NULL);
-    }
 
     if (! file_had_user_group)
-    {
        g_key_file_set_comment (config->key_file, "user", NULL,
                                user_config_comment, NULL);
-    }
 
     if (! file_had_maildir_group)
-    {
        g_key_file_set_comment (config->key_file, "maildir", NULL,
                                maildir_config_comment, NULL);
-    }
 
-    if (! file_had_search_group) {
+    if (! file_had_search_group)
        g_key_file_set_comment (config->key_file, "search", NULL,
                                search_config_comment, NULL);
-    }
 
     return config;
 }
@@ -455,7 +444,7 @@ int
 notmuch_config_save (notmuch_config_t *config)
 {
     size_t length;
-    char *data;
+    char *data, *filename;
     GError *error = NULL;
 
     data = g_key_file_to_data (config->key_file, &length, NULL);
@@ -464,14 +453,39 @@ notmuch_config_save (notmuch_config_t *config)
        return 1;
     }
 
-    if (! g_file_set_contents (config->filename, data, length, &error)) {
-       fprintf (stderr, "Error saving configuration to %s: %s\n",
-                config->filename, error->message);
+    /* Try not to overwrite symlinks. */
+    filename = realpath (config->filename, NULL);
+    if (! filename) {
+       if (errno == ENOENT) {
+           filename = strdup (config->filename);
+           if (! filename) {
+               fprintf (stderr, "Out of memory.\n");
+               g_free (data);
+               return 1;
+           }
+       } else {
+           fprintf (stderr, "Error canonicalizing %s: %s\n", config->filename,
+                    strerror (errno));
+           g_free (data);
+           return 1;
+       }
+    }
+
+    if (! g_file_set_contents (filename, data, length, &error)) {
+       if (strcmp (filename, config->filename) != 0) {
+           fprintf (stderr, "Error saving configuration to %s (-> %s): %s\n",
+                    config->filename, filename, error->message);
+       } else {
+           fprintf (stderr, "Error saving configuration to %s: %s\n",
+                    filename, error->message);
+       }
        g_error_free (error);
+       free (filename);
        g_free (data);
        return 1;
     }
 
+    free (filename);
     g_free (data);
     return 0;
 }
@@ -690,7 +704,7 @@ _item_split (char *item, char **group, char **key)
 
     *group = item;
 
-    period = index (item, '.');
+    period = strchr (item, '.');
     if (period == NULL || *(period+1) == '\0') {
        fprintf (stderr,
                 "Invalid configuration name: %s\n"