lib: Always add reference terms to the database.

Previously, we were only adding the reference terms for cases where
the referenced message did not yet exist in the database. For thread
presentation, it's useful to have the connection information provided
by the references, even when the messages are present. So add this
term unconditionally.

diff --git a/lib/database.cc b/lib/database.cc
index 415b0d77c3439abb9165d8236c5106d3f1cfffee..ff6f100db98f6db7e4ae237b9c3efb4dfc33093b 100644 (file)
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1313,14 +1313,15 @@ _notmuch_database_link_message_to_parents (notmuch_database_t *notmuch,
        const char *parent_thread_id;
 
        parent_message_id = (char *) l->data;
        const char *parent_thread_id;
 
        parent_message_id = (char *) l->data;

+
+       _notmuch_message_add_term (message, "reference",
+                                  parent_message_id);
+

        parent_thread_id = _resolve_message_id_to_thread_id (notmuch,
                                                             message,
                                                             parent_message_id);
 
        parent_thread_id = _resolve_message_id_to_thread_id (notmuch,
                                                             message,
                                                             parent_message_id);
 

-       if (parent_thread_id == NULL) {
-           _notmuch_message_add_term (message, "reference",
-                                      parent_message_id);
-       } else {
+       if (parent_thread_id != NULL) {

            if (*thread_id == NULL) {
                *thread_id = talloc_strdup (message, parent_thread_id);
                _notmuch_message_add_term (message, "thread", *thread_id);
            if (*thread_id == NULL) {
                *thread_id = talloc_strdup (message, parent_thread_id);
                _notmuch_message_add_term (message, "thread", *thread_id);