]> git.notmuchmail.org Git - notmuch/commitdiff
configure: Fix valgrind check to take effect, and to work.
authorCarl Worth <cworth@cworth.org>
Tue, 1 Dec 2009 23:52:44 +0000 (15:52 -0800)
committerCarl Worth <cworth@cworth.org>
Wed, 2 Dec 2009 00:33:25 +0000 (16:33 -0800)
We were missing an "override" directive in the assignment of CFLAGS
within Makefile.config so it was actually having no effect. Then, we
were also failing to get the proper include path for valgrind.h so
it wouldn't have worked even it were having effect. Fix both problems.

configure

index 2ceda74bc65c3d237ab3449340533b495a086d49..6b571977917f5d7fb9d557915a00a97380c09bfa 100755 (executable)
--- a/configure
+++ b/configure
@@ -61,10 +61,12 @@ fi
 printf "Checking for valgrind development files... "
 if pkg-config --modversion valgrind > /dev/null 2>&1; then
     printf "Yes.\n"
-    have_valgrind=-DHAVE_VALGRIND
+    have_valgrind=1
+    valgrind_flags=$(pkg-config --cflags valgrind)
 else
     printf "No (but that's fine).\n"
-    have_valgrind=
+    have_valgrind=0
+    valgrind_flags=
 fi
 
 if [ $errors -gt 0 ]; then
@@ -137,5 +139,5 @@ EOF
 # construct the Makefile.config
 cat > Makefile.config <<EOF
 prefix = /usr/local
-CFLAGS += ${have_valgrind}
+override CFLAGS += -DHAVE_VALGRIND=${have_valgrind} ${valgrind_flags}
 EOF