notmuch_database_add_message: Add missing error-value propagation.
authorCarl Worth <cworth@cworth.org>
Fri, 20 Nov 2009 20:02:11 +0000 (21:02 +0100)
committerCarl Worth <cworth@cworth.org>
Fri, 20 Nov 2009 20:02:11 +0000 (21:02 +0100)
Thanks to Mike Hommey for doing the analysis that led to noticing that
this was missing.

lib/database.cc

index 294247e22cf938526abd041d9411509707ffa651..58a350d2f59e8368006d681a2508d20453b2254b 100644 (file)
@@ -940,8 +940,11 @@ notmuch_database_add_message (notmuch_database_t *notmuch,
 
        talloc_free (message_id);
 
-       if (message == NULL)
+       if (message == NULL) {
+           ret = COERCE_STATUS (private_status,
+                                "Unexpected status value from _notmuch_message_create_for_message_id");
            goto DONE;
+       }
 
        /* Is this a newly created message object? */
        if (private_status == NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND) {