]> git.notmuchmail.org Git - notmuch/commitdiff
test: searching by absolute date is broken without Xapian FieldProcessor
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Wed, 6 Dec 2017 02:33:22 +0000 (21:33 -0500)
committerDavid Bremner <david@tethera.net>
Tue, 19 Dec 2017 11:14:03 +0000 (07:14 -0400)
Previously, the test suite had simply silently skipped the absolute
date test if we're using an archaic version of Xapian.  For
correctness, we should instead mark the test as broken.

This also changes from string to numeric comparison when checking
NOMTUCH_HAVE_XAPIAN_FIELD_PROCESSOR for consistency with other tests.

test/T500-search-date.sh

index 5c5b99a0e2b0545318764f33b1cbdb329d6db974..f84b0962c25ee5446d94b6208e88035f29c43e1e 100755 (executable)
@@ -12,11 +12,12 @@ test_begin_subtest "Absolute date range with 'same' operator"
 output=$(notmuch search date:2010-12-16..! | notmuch_search_sanitize)
 test_expect_equal "$output" "thread:XXX   2010-12-16 [1/1] Olivier Berger; Essai accentuĂ© (inbox unread)"
 
-if [ "${NOTMUCH_HAVE_XAPIAN_FIELD_PROCESSOR}" = "1" ]; then
-    test_begin_subtest "Absolute date field"
-    output=$(notmuch search date:2010-12-16 | notmuch_search_sanitize)
-    test_expect_equal "$output" "thread:XXX   2010-12-16 [1/1] Olivier Berger; Essai accentuĂ© (inbox unread)"
+test_begin_subtest "Absolute date field"
+output=$(notmuch search date:2010-12-16 | notmuch_search_sanitize)
+if [ $NOTMUCH_HAVE_XAPIAN_FIELD_PROCESSOR -ne 1 ]; then
+    test_subtest_known_broken
 fi
+test_expect_equal "$output" "thread:XXX   2010-12-16 [1/1] Olivier Berger; Essai accentuĂ© (inbox unread)"
 
 test_begin_subtest "Absolute time range with TZ"
 notmuch search date:18-Nov-2009_02:19:26-0800..2009-11-18_04:49:52-06:00 | notmuch_search_sanitize > OUTPUT