When we have not been able to evaluate the signature status of a given
MIME part, showing a content-free (and interaction-free) "[ Unknown
signature status ]" button doesn't really help the user at all, and
takes up valuable screen real-estate.
A visual reminder that a given message is *not* signed isn't helpful
unless it is always present, in which case we'd want to see "[ Unknown
signature status ]" buttons on all messages, even ones that don't have
a signing structure, but i don't think we want that.
Amended by db to drop the unused initialization of 'label'
(defun notmuch-crypto-insert-sigstatus-button (sigstatus from)
(let* ((status (plist-get sigstatus :status))
(help-msg nil)
(defun notmuch-crypto-insert-sigstatus-button (sigstatus from)
(let* ((status (plist-get sigstatus :status))
(help-msg nil)
- (label "Signature not processed")
+ (show-button t)
+ (label nil)
(face 'notmuch-crypto-signature-unknown)
(button-action (lambda (button) (message (button-get button 'help-echo)))))
(cond
(face 'notmuch-crypto-signature-unknown)
(button-action (lambda (button) (message (button-get button 'help-echo)))))
(cond
(let ((keyid (concat "0x" (plist-get sigstatus :keyid))))
(setq label (concat "Bad signature (claimed key ID " keyid ")"))
(setq face 'notmuch-crypto-signature-bad)))
(let ((keyid (concat "0x" (plist-get sigstatus :keyid))))
(setq label (concat "Bad signature (claimed key ID " keyid ")"))
(setq face 'notmuch-crypto-signature-bad)))
+ (status
+ (setq label (concat "Unknown signature status: " status)))
- (setq label (concat "Unknown signature status"
- (if status (concat ": " status))))))
- (insert-button
- (concat "[ " label " ]")
- :type 'notmuch-crypto-status-button-type
- 'help-echo help-msg
- 'face face
- 'mouse-face face
- 'action button-action
- :notmuch-sigstatus sigstatus
- :notmuch-from from)
- (insert "\n")))
+ (setq show-button nil)))
+ (when show-button
+ (insert-button
+ (concat "[ " label " ]")
+ :type 'notmuch-crypto-status-button-type
+ 'help-echo help-msg
+ 'face face
+ 'mouse-face face
+ 'action button-action
+ :notmuch-sigstatus sigstatus
+ :notmuch-from from)
+ (insert "\n"))))
(declare-function notmuch-show-refresh-view "notmuch-show" (&optional reset-state))
(declare-function notmuch-show-refresh-view "notmuch-show" (&optional reset-state))
[ multipart/encrypted ]
[ Decryption successful ]
[ multipart/encrypted ]
[ Decryption successful ]
-[ Unknown signature status ]
[ application/pgp-encrypted ]
[ text/plain ]
The password is "abcd1234!", please do not tell anyone.
[ application/pgp-encrypted ]
[ text/plain ]
The password is "abcd1234!", please do not tell anyone.
[ multipart/encrypted ]
[ Unknown encryption status ]
[ multipart/encrypted ]
[ Unknown encryption status ]
-[ Unknown signature status ]
[ application/pgp-encrypted ]
[ application/octet-stream ]
[ application/pgp-encrypted ]
[ application/octet-stream ]
[ multipart/mixed ]
[ multipart/signed ]
[ multipart/mixed ]
[ multipart/signed ]
- [ Unknown signature status ]
[ text/plain ]
> See the patch just posted here.
[ text/plain ]
> See the patch just posted here.
[ multipart/encrypted ]
[ Decryption error ]
[ multipart/encrypted ]
[ Decryption error ]
-[ Unknown signature status ]
[ application/pgp-encrypted ]
[ application/octet-stream ]
[ application/pgp-encrypted ]
[ application/octet-stream ]