]> git.notmuchmail.org Git - notmuch/commitdiff
test/git: add known broken test for tag with quotes.
authorDavid Bremner <david@tethera.net>
Sun, 10 Apr 2022 17:06:14 +0000 (14:06 -0300)
committerDavid Bremner <david@tethera.net>
Fri, 17 Jun 2022 11:40:19 +0000 (08:40 -0300)
There is current insufficient sanitization and/or escaping of tag names
internally in notmuch-git.

test/T850-git.sh

index 994950ed2857ddf608a02b7ddd23c73da80b76b2..2badc52dee3f7630fa2a39aed01905a2585cda40 100755 (executable)
@@ -19,6 +19,16 @@ git -C tags.git ls-tree -r --name-only HEAD | xargs dirname | sort -u | sed s,ta
 notmuch search --output=messages '*' | sort > EXPECTED
 test_expect_equal_file_nonempty EXPECTED OUTPUT
 
+test_begin_subtest "commit, with quoted tag"
+test_subtest_known_broken
+notmuch git -C clone2.git -p '' clone tags.git
+git -C clone2.git ls-tree -r --name-only HEAD | grep /inbox > BEFORE
+notmuch tag '+"quoted tag"' '*'
+notmuch git -C clone2.git -p '' commit
+notmuch tag '-"quoted tag"' '*'
+git -C clone2.git ls-tree -r --name-only HEAD | grep /inbox > AFTER
+test_expect_equal_file_nonempty BEFORE AFTER
+
 test_begin_subtest "checkout"
 notmuch dump > BEFORE
 notmuch tag -inbox '*'