notmuch
4 years agolib: fix g_hash_table related read-after-free bug
David Bremner [Wed, 22 Feb 2017 10:17:47 +0000 (06:17 -0400)]
lib: fix g_hash_table related read-after-free bug

The two g_hash_table functions (insert, add) have different behaviour
with respect to existing keys. g_hash_table_insert frees the new key,
while g_hash_table_add (which is really g_hash_table_replace in
disguise) frees the existing key. With this change 'ref' is live until
the end of the function (assuming single-threaded access to
'hash'). We can't guarantee it will continue to be live in the
future (i.e. there may be a future key duplication) so we copy it with
the allocation context passed to parse_references (in practice this is
the notmuch_message_t object whose parents we are finding).

Thanks to Tomi for the simpler approach to the problem based on
reading the fine glib manual.

4 years agodebian: start changelog for 0.23.6
David Bremner [Tue, 21 Feb 2017 11:51:44 +0000 (07:51 -0400)]
debian: start changelog for 0.23.6

4 years agoNEWS: news for gpgconf use in test suite
David Bremner [Tue, 21 Feb 2017 11:50:05 +0000 (07:50 -0400)]
NEWS: news for gpgconf use in test suite

4 years agotest: use gpgconf --create-socketdir if available
David Bremner [Tue, 14 Feb 2017 21:42:39 +0000 (16:42 -0500)]
test: use gpgconf --create-socketdir if available

This enables the shortened socket pathes in /run or equivalent. The
explicit call to gpgconf is needed for nonstandard GNUPGHOME settings.

(amended according to id:m2fujatr4k.fsf@guru.guru-group.fi)

4 years agoconfigure: add test for gpgconf --create-socketdir
David Bremner [Tue, 14 Feb 2017 21:42:38 +0000 (16:42 -0500)]
configure: add test for gpgconf --create-socketdir

This is primarily intended for use in the test suite (since notmuch
builds fine without gnupg installed). Thus we only write the variable
to sh.config.

4 years agoNEWS,debian: set date for release 0.23.5 debian/0.23.5-1
David Bremner [Mon, 9 Jan 2017 10:25:01 +0000 (06:25 -0400)]
NEWS,debian: set date for release

4 years agodocs: add 2017 to copyright years
David Bremner [Sun, 8 Jan 2017 12:35:17 +0000 (08:35 -0400)]
docs: add 2017 to copyright years

4 years agobump version to 0.23.5
David Bremner [Sun, 8 Jan 2017 12:32:56 +0000 (08:32 -0400)]
bump version to 0.23.5

4 years agodebian: changelog for 0.23.5-1
David Bremner [Sun, 8 Jan 2017 12:31:28 +0000 (08:31 -0400)]
debian: changelog for 0.23.5-1

4 years agoNEWS for 0.23.5
David Bremner [Sun, 8 Jan 2017 12:30:08 +0000 (08:30 -0400)]
NEWS for 0.23.5

4 years agoconfigure: fix $prefix expansion for libdir_expanded
Tomi Ollila [Sun, 1 Jan 2017 17:20:30 +0000 (19:20 +0200)]
configure: fix $prefix expansion for libdir_expanded

Since the sed expansion line which did $prefix expansion for
libdir_expanded was changed from the legacy `...` format to the
new $(...) expression, the subtle backslash expansion change went
unnoticed -- \\$ which used to escape '$' now escapes '\' and the
following '$prefix' was attempted to expand as a variable. So
changing \\$ to \$ fixes this.

Also, replaced echo with printf %s -- echo does expansions of its own.

While at it, the following 2 inconsistencies were fixed:
 1) the /g flag was removed from first expression; second didn't have it
 2) first expression did not end with /, so "dropped" it from second

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

4 years agoversion: update to 0.23.4 0.23.4 debian/0.23.4-1
David Bremner [Sat, 24 Dec 2016 08:52:11 +0000 (17:52 +0900)]
version: update to 0.23.4

4 years agoset date in NEWS and debian/changelog
David Bremner [Sat, 24 Dec 2016 08:48:16 +0000 (17:48 +0900)]
set date in NEWS and debian/changelog

pentultimate prepartions for release

4 years agodebian: remove setting of emacslispdir
David Bremner [Thu, 22 Dec 2016 23:34:30 +0000 (08:34 +0900)]
debian: remove setting of emacslispdir

With dh-elpa, this setting is no longer used

4 years agodebian: changelog stanza for 0.23.4-1
David Bremner [Sun, 18 Dec 2016 11:48:48 +0000 (20:48 +0900)]
debian: changelog stanza for 0.23.4-1

4 years agoNEWS: announce autoload fix
David Bremner [Thu, 8 Dec 2016 00:45:52 +0000 (20:45 -0400)]
NEWS: announce autoload fix

4 years agoemacs: restore autoload cookie for notmuch-search
David Bremner [Thu, 8 Dec 2016 00:45:51 +0000 (20:45 -0400)]
emacs: restore autoload cookie for notmuch-search

The cookie only applies to next form, so in the previous location it
applied to the put, rather than the function.

4 years agoNEWS: news for notmuch-insert error handling
David Bremner [Wed, 7 Dec 2016 11:27:13 +0000 (07:27 -0400)]
NEWS: news for notmuch-insert error handling

4 years agocli/insert: document the use of EX_TEMPFAIL
David Bremner [Wed, 7 Dec 2016 11:27:12 +0000 (07:27 -0400)]
cli/insert: document the use of EX_TEMPFAIL

5 years agocli/insert: return EX_TEMPFAIL for some errors
David Bremner [Mon, 28 Nov 2016 03:01:42 +0000 (23:01 -0400)]
cli/insert: return EX_TEMPFAIL for some errors

Attempt to distinguish between errors indicating misconfiguration or
programmer error, which we consider "permanent", in the sense that
automatic retries are unlikely to be useful, and those indicating
transient error conditions. We consider XAPIAN_EXCEPTION transient
because it covers the important special case of locking failure.

5 years agocli/insert: delay database open until after writing mail file
David Bremner [Sun, 27 Nov 2016 15:24:58 +0000 (11:24 -0400)]
cli/insert: delay database open until after writing mail file

The idea is to get the mail written to disk, even if we can't open the
database (e.g. because some other process has a write lock, and notmuch
is compiled for non-blocking opens).

5 years agotest: gdb insert: redirect input inside gdb script
Tomi Ollila [Mon, 28 Nov 2016 21:07:08 +0000 (23:07 +0200)]
test: gdb insert: redirect input inside gdb script

Running `gdb command < input` is not as reliable way to give input
to the command (some installations of gdb consume it). Use "set args"
gdb command to have input redirected at gdb 'run' time.

5 years agodebian: changelog stanza for 0.23.3-3
David Bremner [Mon, 5 Dec 2016 12:26:28 +0000 (08:26 -0400)]
debian: changelog stanza for 0.23.3-3

5 years agodebian: disable gdb using tests on kfreebsd-*
David Bremner [Mon, 5 Dec 2016 12:22:57 +0000 (08:22 -0400)]
debian: disable gdb using tests on kfreebsd-*

gdb seems broken there.

5 years agodebian: fix transition package for notmuch-emacs
David Bremner [Thu, 1 Dec 2016 12:08:14 +0000 (08:08 -0400)]
debian: fix transition package for notmuch-emacs

The current version is more a transition to nowhere.

5 years agoNEWS: fix date and title 0.23.3
David Bremner [Sun, 27 Nov 2016 01:54:10 +0000 (21:54 -0400)]
NEWS: fix date and title

5 years agoNEWS: note disappearing files fix for notmuch new
David Bremner [Sat, 26 Nov 2016 12:41:47 +0000 (08:41 -0400)]
NEWS: note disappearing files fix for notmuch new

5 years agoNEWS: set date
David Bremner [Sat, 26 Nov 2016 12:39:32 +0000 (08:39 -0400)]
NEWS: set date

5 years agodebian: finalize? changelog for 0.23.3-1
David Bremner [Sat, 26 Nov 2016 12:38:13 +0000 (08:38 -0400)]
debian: finalize? changelog for 0.23.3-1

5 years agocli/new: document new exit code
David Bremner [Sat, 26 Nov 2016 02:40:37 +0000 (22:40 -0400)]
cli/new: document new exit code

It seems important to give the numeric return code for people writing
scripts. Hopefully deviations from this convention are rare.

5 years agocli: consider files vanishing during notmuch new non-fatal
Jani Nikula [Mon, 21 Nov 2016 20:14:33 +0000 (22:14 +0200)]
cli: consider files vanishing during notmuch new non-fatal

If some software other than notmuch new renames or removes files
during the notmuch new scan (specifically after scandir but before
indexing the file), keep going instead of bailing out. Failing to
index the file is just a race condition between notmuch and the other
software; the rename could happen after the notmuch new scan
anyway. It's not fatal, and we'll catch the renamed files on the next
scan.

Add a new exit code for when files vanished, so the caller has a
chance to detect the race and re-run notmuch new to recover.

Reported by Paul Wise <pabs@debian.org> at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843127

5 years agodebian: start changelog stanza for 0.23.3-1
David Bremner [Fri, 25 Nov 2016 00:30:58 +0000 (20:30 -0400)]
debian: start changelog stanza for 0.23.3-1

5 years agoversion: bump to 0.23.3
David Bremner [Fri, 25 Nov 2016 00:29:18 +0000 (20:29 -0400)]
version: bump to 0.23.3

5 years agoNEWS: note gnupg related test-suite fix
David Bremner [Fri, 25 Nov 2016 00:28:27 +0000 (20:28 -0400)]
NEWS: note gnupg related test-suite fix

5 years agodebian: disable dh_elpa_test
David Bremner [Fri, 25 Nov 2016 00:16:24 +0000 (20:16 -0400)]
debian: disable dh_elpa_test

Currently it seems to interfere with running the notmuch test suite.
In any case we have no ert / buttercup format tests to run.

5 years agotests: account for varying-size cryptographic signatures
Daniel Kahn Gillmor [Wed, 23 Nov 2016 17:57:22 +0000 (12:57 -0500)]
tests: account for varying-size cryptographic signatures

GnuPG 2.1.16 is now injecting the full issuer fingerprint in its
signatures, which makes them about 32 octets larger when
ascii-armored.

This change in size means that the size of the MIME parts will vary
depending on the version of gpg that the user has installed.  at any
rate, the signature part should be non-zero (this is true for
basically any MIME part), so we just test for that instead of an exact
size.

5 years agoNEWS: set date for release 0.23.2
David Bremner [Sun, 20 Nov 2016 12:23:33 +0000 (08:23 -0400)]
NEWS: set date for release

5 years agoNEWS for notmuch-cycle-notmuch-buffers
Mark Walters [Fri, 18 Nov 2016 09:02:27 +0000 (09:02 +0000)]
NEWS for notmuch-cycle-notmuch-buffers

5 years agoNEWS: document fixes for emacs23
David Bremner [Thu, 17 Nov 2016 12:18:20 +0000 (08:18 -0400)]
NEWS: document fixes for emacs23

5 years agodebian: changelog stanza for 0.23.2-1
David Bremner [Fri, 11 Nov 2016 11:46:52 +0000 (07:46 -0400)]
debian: changelog stanza for 0.23.2-1

5 years agoversion: bump to 0.23.2
David Bremner [Thu, 17 Nov 2016 01:52:50 +0000 (21:52 -0400)]
version: bump to 0.23.2

5 years agodebian: convert to use dh-elpa
David Bremner [Fri, 11 Nov 2016 11:46:51 +0000 (07:46 -0400)]
debian: convert to use dh-elpa

This packaging helper eliminates most of the boilerplate from packaging
emacs extensions for debian. It requires package.el compatible metadata.

5 years agoemacs: generate notmuch-pkg.el
David Bremner [Fri, 11 Nov 2016 11:46:50 +0000 (07:46 -0400)]
emacs: generate notmuch-pkg.el

This file contains metadata for the built in (as of emacs 24) packaging
system.

5 years agoemacs: add compatibility functions for emacs 23
Mark Walters [Tue, 15 Nov 2016 19:48:45 +0000 (19:48 +0000)]
emacs: add compatibility functions for emacs 23

Some of the recent changes to the emacs code have used functions
introduced in emacs 24. The functions used are read-char-choice and
setq-local. This changeset adds a file notmuch-compat.el which
contains compatibility functions so that it should work on emacs
23.

Note, since these functions are taken almost unchanged from the emacs
source they are copyright the Free Software Foundation, and the header
in the file reflects that.

5 years agoemacs: interesting-buffer bugfixes/updates
Mark Walters [Sat, 22 Oct 2016 12:10:04 +0000 (13:10 +0100)]
emacs: interesting-buffer bugfixes/updates

The command notmuch-interesting-buffer has got out of date -- it
doesn't mention notmuch-tree, and it still refers to message-mode not
notmuch-message-mode. Update both of these.

This fixes the bug that notmuch-cycle-notmuch-buffers does not include
notmuch-tree or notmuch-message-mode buffers in its cycling.

5 years agofinalize release 0.23.1 0.23.1
David Bremner [Mon, 24 Oct 2016 01:06:39 +0000 (22:06 -0300)]
finalize release 0.23.1

5 years agodebian: start changelog stanza for 0.23.1
David Bremner [Sat, 22 Oct 2016 15:39:11 +0000 (12:39 -0300)]
debian: start changelog stanza for 0.23.1

5 years agoversion: bump to 0.23.1
David Bremner [Sat, 22 Oct 2016 15:35:25 +0000 (12:35 -0300)]
version: bump to 0.23.1

5 years agoNEWS for two bugfixes
Mark Walters [Sat, 22 Oct 2016 06:45:17 +0000 (07:45 +0100)]
NEWS for two bugfixes

This adds news items for the two bugs

    emacs: search face bugfix
and
    emacs: fix notmuch-search-line-faces defcustom

5 years agoExpand docstrings about fcc using notmuch-insert
Keith Amidon [Wed, 19 Oct 2016 10:05:19 +0000 (03:05 -0700)]
Expand docstrings about fcc using notmuch-insert

This commit expands docstrings for notmuch-fcc-dirs and
notmuch-maildir-fcc-with-notmuch-insert to describe how quoted strings
are processed and make the ability to configure sent folders containing
whitespace more discoverable.

5 years agotest: use vt100 as "smart" terminal for known dumb/unknown terminals
Tomi Ollila [Thu, 20 Oct 2016 08:19:45 +0000 (11:19 +0300)]
test: use vt100 as "smart" terminal for known dumb/unknown terminals

Otherwise use whatever user environment has set for TERM so
that there is more chance to test on users' actual environments.

5 years agotest-lib.sh: rename $DTACH_TERM to $SMART_TERM
Tomi Ollila [Thu, 20 Oct 2016 08:19:44 +0000 (11:19 +0300)]
test-lib.sh: rename $DTACH_TERM to $SMART_TERM

5 years agoNEWS for 0.23.1
David Bremner [Wed, 12 Oct 2016 02:01:56 +0000 (23:01 -0300)]
NEWS for 0.23.1

5 years agoemacs: search face bugfix
Mark Walters [Wed, 12 Oct 2016 07:39:21 +0000 (08:39 +0100)]
emacs: search face bugfix

In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default faces
for unread and flagged were accidentally swapped. This swaps them back.

5 years agoemacs: fix notmuch-search-line-faces defcustom
Mark Walters [Sat, 15 Oct 2016 09:40:48 +0000 (10:40 +0100)]
emacs: fix notmuch-search-line-faces defcustom

In commit 2a7b11b064233afc4feead876fa396e3c18a6b91 the default value
for notmuch-search-line-faces was changed so that it didn't match the
specification in the corresponding defcustom. This meant that it was
difficult for the user to customize this variable as they got a type
mismatch error.

Note anyone who had already customised this variable would not see
this bug as their customisation would match the defcustom.

5 years agoemacs/show: force notmuch-show-buttonise-links to act on lines
David Bremner [Sun, 9 Oct 2016 22:30:44 +0000 (19:30 -0300)]
emacs/show: force notmuch-show-buttonise-links to act on lines

This seems to fix a problem with emacs 25 creating partial buttons by
calling n-s-b-l with a region that does not include the whole button.
I'm not 100% sure it's legit to act outside the region passed by
jit-lock, but goto-address-fontify-region (where I borrowed the code
from) already does this, so this patch to not make things worse.

5 years agolib: document API added in 0.23
David Bremner [Wed, 5 Oct 2016 01:12:56 +0000 (22:12 -0300)]
lib: document API added in 0.23

The API was already documented, but for future readers note when the
functions were added,

5 years agorequire xapian >= 1.2.6
David Bremner [Wed, 5 Oct 2016 00:35:23 +0000 (21:35 -0300)]
require xapian >= 1.2.6

It seems that no-one tried to compile without Xapian compact support
since March of 2015, since that's when I introduced a syntax error in
that branch of the ifdef.

Given the choice of maintaining this underused branch of code, or
bumping the Xapian dependency to a version from 2011, it seems
reasonable to do the latter.

5 years agodebian: changelog stanza for 0.23-2
David Bremner [Thu, 6 Oct 2016 00:27:17 +0000 (21:27 -0300)]
debian: changelog stanza for 0.23-2

5 years agodebian: changelog stanza for 0.23-1 0.23
David Bremner [Tue, 4 Oct 2016 01:47:21 +0000 (22:47 -0300)]
debian: changelog stanza for 0.23-1

5 years agoNEWS: bump date to today
David Bremner [Tue, 4 Oct 2016 01:43:23 +0000 (22:43 -0300)]
NEWS: bump date to today

5 years agoversion: bump to 0.23
David Bremner [Tue, 4 Oct 2016 01:40:22 +0000 (22:40 -0300)]
version: bump to 0.23

5 years agolib: bump minor version to mark added symbols
David Bremner [Sun, 2 Oct 2016 01:11:56 +0000 (22:11 -0300)]
lib: bump minor version to mark added symbols

This should not change the SONAME, and therefore won't change the
dynamic linking behaviour, but it may help some users debug missing
symbols in case their libnotmuch is too old.

5 years agodebian: changelog stanza for 0.23~rc1-1 0.23_rc1 debian/0.23_rc1-1
David Bremner [Fri, 30 Sep 2016 10:21:09 +0000 (07:21 -0300)]
debian: changelog stanza for 0.23~rc1-1

5 years agoversion: update to 0.23~rc1
David Bremner [Fri, 30 Sep 2016 10:18:04 +0000 (07:18 -0300)]
version: update to 0.23~rc1

5 years agoconfigure: set platform variables also when `uname` is unrecognized
Tomi Ollila [Thu, 29 Sep 2016 13:12:49 +0000 (16:12 +0300)]
configure: set platform variables also when `uname` is unrecognized

Since commit

124a67e96ecab5495c0f17b6875d53dfd67ff137: configure: add set -u

all variables must be set before their expansion are attempted. These
2 variables: "platform" and "linker_resolves_library_dependencies" were
not given value in the final 'else' branch when platform check failed
due to unrecognized kernel name (output of `uname`). Now those two are
given reasonable non-empty values.

5 years agoemacs: fcc: say we are doing Fcc
Mark Walters [Thu, 29 Sep 2016 13:44:04 +0000 (14:44 +0100)]
emacs: fcc: say we are doing Fcc

Since doing the Fcc with notmuch insert could be slow (if the indexing
takes some time) add a message saying we are doing it.

5 years agoemacs: document notmuch-fcc-dirs
Mark Walters [Wed, 28 Sep 2016 10:03:46 +0000 (11:03 +0100)]
emacs: document notmuch-fcc-dirs

This updates the docstring for the variable notmuch-fcc-dirs to match
the new insert code.

5 years agoNEWS: add news for fcc insert and address completion changes
Mark Walters [Wed, 28 Sep 2016 12:33:54 +0000 (13:33 +0100)]
NEWS: add news for fcc insert and address completion changes

5 years agolib/database.cc: fix misleading indentation
Tomi Ollila [Tue, 27 Sep 2016 15:06:52 +0000 (18:06 +0300)]
lib/database.cc: fix misleading indentation

Found by gcc 6.1.1 -Wmisleading-indentation option (set by -Wall).

5 years agoNEWS: emacs notmuch-show-resend-message
Tomi Ollila [Tue, 27 Sep 2016 17:24:41 +0000 (20:24 +0300)]
NEWS: emacs notmuch-show-resend-message

5 years agoNEWS: mention message properties API, dump/restore
David Bremner [Sun, 25 Sep 2016 11:36:52 +0000 (08:36 -0300)]
NEWS: mention message properties API, dump/restore

5 years agoNEWS: fix headline for go bindings NEWS
David Bremner [Sun, 25 Sep 2016 11:33:26 +0000 (08:33 -0300)]
NEWS: fix headline for go bindings NEWS

5 years agoNEWS: note notmuch-reply refactor
David Bremner [Sun, 25 Sep 2016 11:30:49 +0000 (08:30 -0300)]
NEWS: note notmuch-reply refactor

5 years agoNEWS: note dropping of User-Agent header
David Bremner [Sun, 25 Sep 2016 11:22:50 +0000 (08:22 -0300)]
NEWS: note dropping of User-Agent header

5 years agoNEWS: document mtime bugfix
David Bremner [Sun, 25 Sep 2016 11:12:40 +0000 (08:12 -0300)]
NEWS: document mtime bugfix

5 years agoemacs: tree: make b bounce a message and backspace scroll message pane up
Mark Walters [Sun, 25 Sep 2016 07:18:10 +0000 (08:18 +0100)]
emacs: tree: make b bounce a message and backspace scroll message pane up

This tweaks the keybindings in tree-mode. It make b do bounce/resend
matching show-mode. Since b was already bound to scroll message pane
back, we now use backspace for that.

This means space/backspace scroll the message pane forwards/backwards,
and page-up/page-down scrolls the tree pane forwards/backwards.

5 years agodebian: update symbols for 0.23 0.23_rc0 debian/0.23_rc0-1
David Bremner [Mon, 26 Sep 2016 10:39:25 +0000 (07:39 -0300)]
debian: update symbols for 0.23

New sub-APIs: config, built_with, message_property. A new exception used
internally. Mark the exception as optional, as it only shows up when
built against Xapian supporting FieldProcessors

5 years agodebian: changelog stanza for 0.23~rc0-1
David Bremner [Mon, 26 Sep 2016 10:30:15 +0000 (07:30 -0300)]
debian: changelog stanza for 0.23~rc0-1

5 years agoversion: bump to 0.23~rc0
David Bremner [Mon, 26 Sep 2016 10:22:21 +0000 (07:22 -0300)]
version: bump to 0.23~rc0

5 years agoemacs: tag deleted face bugfix
Mark Walters [Sun, 18 Sep 2016 10:57:32 +0000 (11:57 +0100)]
emacs: tag deleted face bugfix

Commit d25d33ff cleaned up some of the tag face code. However, for the
face notmuch-tag-deleted it used the test

((class color) (supports :strike-through))

to decide whether to use red strikethrough or inverse-video (emacs in
a terminal typically doesn't support red strikethrough, but in X it does).

However, it seems that test often returns true even though red
strikethrough is not supported. This breaks the tag update code -- the
wrong thing is displayed to the user.

Thus we make the test explicitly more specific, changing the test to

((class color) (supports :strike-through "red"))

5 years agotest: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch
Tomi Ollila [Sat, 24 Sep 2016 12:43:27 +0000 (15:43 +0300)]
test: test-lib.sh: use $BASH instead of ${SHELL-sh} to relaunch

In case of the test script is to be relaunced under valgrind, or --tee
is requested, use the $BASH shell variable to locate the command
interpreter. The $SHELL variable is re-set by non-interactive shells
so in case the shell uses some other shell (e.g. zsh) for interactive
use these bash scripts continue to work.

5 years agolib: add talloc reference from string map iterator to map
David Bremner [Fri, 23 Sep 2016 09:33:19 +0000 (06:33 -0300)]
lib: add talloc reference from string map iterator to map

This is needed so that when the map is modified during traversal, and
thus unlinked by the database code, the map is not disposed of until the
iterator is done with it.

5 years agoemacs: tree: make jump close message pane
Mark Walters [Mon, 19 Sep 2016 09:39:49 +0000 (10:39 +0100)]
emacs: tree: make jump close message pane

j is in the global notmuch keymap bound to notmuch jump. In tree-mode
it makes sense to close the message pane first (otherwise the new
search runs in the small top pane of tree-mode).

5 years agotest/emacs: add broken test for message replying to msg to self
David Bremner [Tue, 13 Sep 2016 02:24:43 +0000 (23:24 -0300)]
test/emacs: add broken test for message replying to msg to self

This is a strange corner case where the removing of the user's address
from the To: header does the wrong thing. If we think it is
worth (eventually) fixing, this test can serve as a reminder.

5 years agoNEWS: fix markup of CONSTANTS_WITH_UNDERSCORES
David Bremner [Fri, 23 Sep 2016 23:58:32 +0000 (20:58 -0300)]
NEWS: fix markup of CONSTANTS_WITH_UNDERSCORES

Alas, I did not notice when when I originally applied the NEWS patch

5 years agoNEWS: news for Xapian 1.4 enabled features
David Bremner [Sat, 17 Sep 2016 13:07:44 +0000 (10:07 -0300)]
NEWS: news for Xapian 1.4 enabled features

In fact some of these features are available in Xapian 1.3.x development
releases, but these are not really widely packaged. In any case, the
experts who are using development releases of Xapian can figure that
out.

5 years agotest: fix printf format
David Bremner [Thu, 22 Sep 2016 11:11:42 +0000 (08:11 -0300)]
test: fix printf format

notmuch_status_t is an integer type, printing it as a string is a very
bad idea.

5 years agobuild system: choose gnu99 as a C standard
David Bremner [Wed, 21 Sep 2016 23:09:14 +0000 (20:09 -0300)]
build system: choose gnu99 as a C standard

Apparently pre 5.1 gcc defaulted to gnu89, but we decided it was ok to
use some c99 features.

'-std=c99' by itself is not enough for notmuch to compile.

'-std=gnu99' seems to work with clang and gcc, so I'm not convinced
configuration support is needed.

5 years agoadd property: query prefix to search for specific properties
Daniel Kahn Gillmor [Fri, 8 Jul 2016 09:15:36 +0000 (11:15 +0200)]
add property: query prefix to search for specific properties

We want to be able to query the properties directly, like:

   notmuch count property:foo=bar

which should return a count of messages where the property with key
"foo" has value equal to "bar".

5 years agocli: optionally restore message properties from dump file
David Bremner [Mon, 13 Jun 2016 01:05:55 +0000 (22:05 -0300)]
cli: optionally restore message properties from dump file

This somewhat mimics the config line parsing, except there can be
arbitrarily many key value pairs, so one more level of looping is
required.

5 years agoCLI: add properties to dump output
David Bremner [Mon, 13 Jun 2016 01:05:54 +0000 (22:05 -0300)]
CLI: add properties to dump output

Part of providing extensibility via properties is to make sure that user
data is not lost. Thus we need to be able to dump and restore
properties.

5 years agoCLI: refactor dumping of tags.
David Bremner [Mon, 13 Jun 2016 01:05:53 +0000 (22:05 -0300)]
CLI: refactor dumping of tags.

This is mainly code movement, to make room in the loop over messages for
dumping properties.

5 years agolib: iterator API for message properties
David Bremner [Mon, 13 Jun 2016 01:05:52 +0000 (22:05 -0300)]
lib: iterator API for message properties

This is a thin wrapper around the string map iterator API just introduced.

5 years agolib: extend private string map API with iterators
David Bremner [Mon, 13 Jun 2016 01:05:51 +0000 (22:05 -0300)]
lib: extend private string map API with iterators

Support for prefix based iterators is perhaps overengineering, but I
wanted to mimic the existing database_config API.

5 years agolib: basic message-property API
David Bremner [Mon, 13 Jun 2016 01:05:50 +0000 (22:05 -0300)]
lib: basic message-property API

Initially, support get, set and removal of single key/value pair, as
well as removing all properties.

5 years agolib: private string map (associative array) API
David Bremner [Mon, 13 Jun 2016 01:05:49 +0000 (22:05 -0300)]
lib: private string map (associative array) API

The choice of array implementation is deliberate, for future iterator support

5 years agolib: read "property" terms from messages.
David Bremner [Mon, 13 Jun 2016 01:05:48 +0000 (22:05 -0300)]
lib: read "property" terms from messages.

This is a first step towards providing an API to attach
arbitrary (key,value) pairs to messages and retrieve all of the values
for a given key.

5 years agotest: silence the output of notmuch new mid-test
Jani Nikula [Sun, 11 Sep 2016 15:42:25 +0000 (18:42 +0300)]
test: silence the output of notmuch new mid-test

Fix this during test run:

T470-missing-headers: Testing messages with missing headers
Added 2 new messages to the database.

5 years agoemacs: reply: remove wrong sig/enc status buttons
Mark Walters [Tue, 13 Sep 2016 01:45:58 +0000 (22:45 -0300)]
emacs: reply: remove wrong sig/enc status buttons

This stops the (usually incorrect) sigstatus and encstatus buttons
appearing when replying in emacs, and updates the test suite to match.

Overriding the status button functions is a little unusual but much
less intrusive than passing an argument all the way down the call
chain. It also makes it clear exactly what it does.

We also hide the application/pgp-encrypted part as it can only contain
"Version: 1". We do this in notmuch show, which means it also happens
when replying.