]> git.notmuchmail.org Git - notmuch/commitdiff
test/crypto: clarify the difference between ownertrust and validity
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Sat, 4 May 2019 21:33:26 +0000 (17:33 -0400)
committerDavid Bremner <david@tethera.net>
Tue, 7 May 2019 09:42:01 +0000 (06:42 -0300)
This is a subtle difference, but the output of notmuch shouldn't ever
change based on ownertrust itself -- notmuch is intended to show valid
User IDs, and to avoid showing invalid User IDs.

It so happens that setting ownertrust of a key to ultimate sets all
associated user IDs to "full" validity, so the test is correct, but
just misnamed.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
test/T350-crypto.sh

index 6045a7dc3d0b764c4546531174db13456d35b084..bd369f8ffaa828fa84fb8b061e8d1a3815b56f50 100755 (executable)
@@ -135,8 +135,9 @@ test_expect_equal_json \
     "$output" \
     "$expected"
 
-test_begin_subtest "signature verification with full owner trust"
-# give the key full owner trust
+test_begin_subtest "signature verification with full user ID validity"
+# give the key ultimate owner trust, which confers full validity on
+# all user IDs in the certificate:
 echo "${FINGERPRINT}:6:" | gpg --no-tty --import-ownertrust >>"$GNUPGHOME"/trust.log 2>&1
 gpg --no-tty --check-trustdb >>"$GNUPGHOME"/trust.log 2>&1
 output=$(notmuch show --format=json --verify subject:"test signed message 001" \