]> git.notmuchmail.org Git - notmuch/commitdiff
test/emacs: revert invalid-from test to pre-86f89385 behaviour
authorDavid Bremner <david@tethera.net>
Sun, 12 May 2019 02:45:59 +0000 (20:45 -0600)
committerDavid Bremner <david@tethera.net>
Mon, 20 May 2019 19:31:28 +0000 (16:31 -0300)
To the best of my understanding, this original behaviour was what
Carl's homebrew parser produced. With commit 86f89385 Austin switched
to using GMime (2.6). This produced arguably worse results, but since
the input was bad, we could live with it. Now with GMime 3.0 we are
getting the original results again, and there is no reason to consider
this test broken.

test/T310-emacs.sh

index c06a8133e0faff9155e38e789e7b9b1538abee48..5f74305dd3ef912f8fd49dfb7b87086eee0acd26 100755 (executable)
@@ -86,14 +86,13 @@ test_emacs "(let ((notmuch-show-indent-messages-width 4))
 test_expect_equal_file $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation OUTPUT
 
 test_begin_subtest "notmuch-show for message with invalid From"
-test_subtest_known_broken
 add_message "[subject]=\"message-with-invalid-from\"" \
            "[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
 thread=$(notmuch search --output=threads subject:message-with-invalid-from)
 test_emacs "(notmuch-show \"$thread\")
            (test-output \"OUTPUT.raw\")"
 cat <<EOF >EXPECTED
-"Invalid " (2001-01-05) (inbox)
+Invalid " From <test_suite@notmuchmail.org> (2001-01-05) (inbox)
 Subject: message-with-invalid-from
 To: Notmuch Test Suite <test_suite@notmuchmail.org>
 Date: GENERATED_DATE