notmuch
8 years agolib: Perform the same transformation to _notmuch_database_find_directory_id
Austin Clements [Fri, 18 May 2012 04:13:35 +0000 (00:13 -0400)]
lib: Perform the same transformation to _notmuch_database_find_directory_id

Now _notmuch_database_find_directory_id takes a flags argument, which
it passes through to _notmuch_directory_create and can indicate if the
directory does not exist.  Again, callers have been updated, but
retain their original behavior.

8 years agolib: Make directory document creation optional for _notmuch_directory_create
Austin Clements [Fri, 18 May 2012 04:13:34 +0000 (00:13 -0400)]
lib: Make directory document creation optional for _notmuch_directory_create

Previously this function would create directory documents if they
didn't exist.  As a result, it could only be used on writable
databases.  This adds an argument to make creation optional and to
make this function work on read-only databases.  We use a flag
argument to avoid a bare boolean and to permit future expansion.

Both callers have been updated, but currently retain the old behavior.
We'll take advantage of the new argument in the following patches.

8 years agoemacs: use 'gnus-decoded in notmuch-mm-display-part-inline ()
Tomi Ollila [Sun, 20 May 2012 16:58:14 +0000 (19:58 +0300)]
emacs: use 'gnus-decoded in notmuch-mm-display-part-inline ()

When mail message is read from emacs, the message structure
obtained may contain parts which have content included
(`text/plain` for example) and other parts where content is not
included (`text/html` for example).

In case content is included, the string is already available in
emacs' internal format and therefore mm-... functions should not
attempt to do further decoding for the data in temp buffer
provided for it.

Currently when reply buffer is created,
notmuch-mm-display-part-inline () is used to provided quoted reply
content. This change makes the mm-... functions called by it use
'gnus-decoded as charset whenever the content is already available.

File .../emacs-23.3/lisp/gnus/mm-uu.el mentions:
"`gnus-decoded' is a fake charset, which means no further decoding."

8 years agodebian: fix typo in changelog.
David Bremner [Wed, 16 May 2012 16:49:23 +0000 (13:49 -0300)]
debian: fix typo in changelog.

the path for NEWS was wrong
(cherry picked from commit b9520ef033ea9ae54507f94f7258641a6a1ad2e6)

8 years agoNEWS: Capitalized go bindings changes title
Tomi Ollila [Wed, 16 May 2012 07:21:50 +0000 (10:21 +0300)]
NEWS: Capitalized go bindings changes title

Align 'Go bindings changes' title capitalization to rest of the file

8 years agoNEWS: Insert markdown formatting commands in 0.13 section text
Tomi Ollila [Wed, 16 May 2012 07:21:49 +0000 (10:21 +0300)]
NEWS: Insert markdown formatting commands in 0.13 section text

NEWS entries in section 0.13 is brought consistent with rest of the
NEWS file.

8 years agoNEWS: Changed 0.13 release date in NEWS file to 2012-05-15
Tomi Ollila [Wed, 16 May 2012 07:21:48 +0000 (10:21 +0300)]
NEWS: Changed 0.13 release date in NEWS file to 2012-05-15

8 years agoNEWS: Dropped old 'Reply to sender' section
Tomi Ollila [Wed, 16 May 2012 07:21:47 +0000 (10:21 +0300)]
NEWS: Dropped old 'Reply to sender' section

'Reply to sender' section was 0.12 news which was accidentally
duplicated in 0.13 news

8 years agodebian: changelog stanza for 0.13 0.13
David Bremner [Tue, 15 May 2012 21:26:48 +0000 (18:26 -0300)]
debian: changelog stanza for 0.13

My usual lazy self, refer to upstream NEWS.

8 years agoversion: bump to 0.13
David Bremner [Tue, 15 May 2012 21:18:45 +0000 (18:18 -0300)]
version: bump to 0.13

8 years agoadd NEWS item about new emacs tagging interface.
Jameson Graef Rollins [Tue, 15 May 2012 16:26:42 +0000 (09:26 -0700)]
add NEWS item about new emacs tagging interface.

This is fairly important to mention, since it represents a user
interface change.

8 years agodebian: recommend notmuch-mutt as an alternative user interface
Stefano Zacchiroli [Tue, 15 May 2012 13:12:25 +0000 (15:12 +0200)]
debian: recommend notmuch-mutt as an alternative user interface

Recommend all notmuch UI (including notmuch-mutt) as alternatives, to
avoid unneeded vim/emacs installation.

Thanks Matteo F. Vescovi for the patch.

Closes: #673011

8 years agonews: Update for changes to notmuch_database_get_directory
Austin Clements [Sun, 13 May 2012 23:36:13 +0000 (19:36 -0400)]
news: Update for changes to notmuch_database_get_directory

8 years agoruby: Update for changes to notmuch_database_get_directory
Austin Clements [Sun, 13 May 2012 23:36:12 +0000 (19:36 -0400)]
ruby: Update for changes to notmuch_database_get_directory

8 years agopython: Update for changes to notmuch_database_get_directory
Austin Clements [Sun, 13 May 2012 23:36:11 +0000 (19:36 -0400)]
python: Update for changes to notmuch_database_get_directory

notmuch_database_get_directory now returns
NOTMUCH_STATUS_READ_ONLY_DATABASE on its own (rather than crashing) so
the workaround in Database.get_directory is no longer necessary.

8 years agogo: Update for changes to notmuch_database_get_directory
Austin Clements [Sun, 13 May 2012 23:36:10 +0000 (19:36 -0400)]
go: Update for changes to notmuch_database_get_directory

8 years agolib/cli: Make notmuch_database_get_directory return a status code
Austin Clements [Sun, 13 May 2012 23:36:09 +0000 (19:36 -0400)]
lib/cli: Make notmuch_database_get_directory return a status code

Previously, notmuch_database_get_directory had no way to indicate how
it had failed.  This changes its prototype to return a status code and
set an out-argument to the retrieved directory, like similar functions
in the library API.  This does *not* change its currently broken
behavior of creating directory objects when they don't exist, but it
does document it and paves the way for fixing this.  Also, it can now
check for a read-only database and return
NOTMUCH_STATUS_READ_ONLY_DATABASE instead of crashing.

In the interest of atomicity, this also updates calls from the CLI so
that notmuch still compiles.

8 years agoNEWS: add an entry for the go 1 compatibility
Justus Winter [Sat, 12 May 2012 13:43:23 +0000 (15:43 +0200)]
NEWS: add an entry for the go 1 compatibility

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: format the souce code using gofmt
Justus Winter [Wed, 9 May 2012 11:15:20 +0000 (13:15 +0200)]
go: format the souce code using gofmt

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: update the build system
Justus Winter [Wed, 9 May 2012 11:15:19 +0000 (13:15 +0200)]
go: update the build system

The new "go" utility does not require any Makefiles to compile go
packages and programs. Remove the old Makefiles and replace the top
level Makefile with one defining some convenience targets for
compiling the notmuch bindings and the notmuch-addrlookup utility.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: update the addrlookup utility to go 1
Justus Winter [Wed, 9 May 2012 11:15:18 +0000 (13:15 +0200)]
go: update the addrlookup utility to go 1

Use the new built in error type that replaces os.Error, adapt the code
to the fact that strings.Split has just two arguments now.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: set LDFLAGS to -lnotmuch in the packages source file
Justus Winter [Wed, 9 May 2012 11:15:17 +0000 (13:15 +0200)]
go: set LDFLAGS to -lnotmuch in the packages source file

Set the LDFLAGS to -lnotmuch so the resulting go package will be
linked with libnotmuch.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: reorganize the go bindings
Justus Winter [Wed, 9 May 2012 11:15:16 +0000 (13:15 +0200)]
go: reorganize the go bindings

go 1 introduced the "go" program that simplifies building of libraries
and programs. This patch reorganizes the go code so it can be compiled
using the new utility, it does not change any files.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: define the constant STATUS_UNBALANCED_ATOMIC
Justus Winter [Wed, 9 May 2012 10:23:08 +0000 (12:23 +0200)]
go: define the constant STATUS_UNBALANCED_ATOMIC

Add the constant STATUS_UNBALANCED_ATOMIC to the list of notmuch
status codes.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: fix the notmuch status constants
Justus Winter [Wed, 9 May 2012 10:23:07 +0000 (12:23 +0200)]
go: fix the notmuch status constants

Formerly all the constants were set to zero since in golang constants
are set to the previous value if no new value is specified. Use the
iota operator that is incremented after each use to fix this issue.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: update notmuch-addrlookup to the new API
Justus Winter [Wed, 9 May 2012 10:23:06 +0000 (12:23 +0200)]
go: update notmuch-addrlookup to the new API

notmuch.OpenDatabase now returns a status indicating success or
failure. Use this information to inform the user of any failures.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agodebian: fix suite debian/0.13_rc1-2
David Bremner [Wed, 9 May 2012 00:40:41 +0000 (21:40 -0300)]
debian: fix suite

Since I already pushed a tag 0.13_rc-1, let's just increment the
debian version to keep everything tidy.

8 years agobump version to 0.13~rc1 0.13_rc1 debian/0.13_rc1-1
David Bremner [Tue, 8 May 2012 17:49:08 +0000 (14:49 -0300)]
bump version to 0.13~rc1

8 years agoruby: Add wrapper for notmuch_query_set_omit_excluded()
Ali Polatel [Mon, 7 May 2012 15:02:46 +0000 (18:02 +0300)]
ruby: Add wrapper for notmuch_query_set_omit_excluded()

8 years agoruby: Add workarounds to use in-tree build not the installed one
Ali Polatel [Mon, 7 May 2012 15:02:45 +0000 (18:02 +0300)]
ruby: Add workarounds to use in-tree build not the installed one

- Make mkmf use the notmuch.h under ../../lib
- Use libnotmuch.a instead of linking to the installed libnotmuch.so

8 years agoruby: Add wrapper for notmuch_query_add_tag_exclude
Ali Polatel [Mon, 7 May 2012 15:02:44 +0000 (18:02 +0300)]
ruby: Add wrapper for notmuch_query_add_tag_exclude

8 years agoruby: Add wrapper for notmuch_query_count_messages
Ali Polatel [Mon, 7 May 2012 15:02:43 +0000 (18:02 +0300)]
ruby: Add wrapper for notmuch_query_count_messages

8 years agoemacs: fix custom queries section customization widget in notmuch-hello
Dmitry Kurochkin [Sat, 5 May 2012 14:39:47 +0000 (18:39 +0400)]
emacs: fix custom queries section customization widget in notmuch-hello

The customization widget referred to a non-existing function
`notmuch-hello-insert-query-list'.  The patch changes it to the
correct one - `notmuch-hello-insert-searches'.  The relevant test is
fixed now.

8 years agotest: add Emacs notmuch-hello tests for custom tags and queries section.
Dmitry Kurochkin [Sat, 5 May 2012 14:39:46 +0000 (18:39 +0400)]
test: add Emacs notmuch-hello tests for custom tags and queries section.

The tests use default values from customization widgets to make sure
that these customization widgets work (at least on basic level).

The custom queries section test is currently broken.

8 years agotest: Force reply to use html2text for consistency
Adam Wolfe Gordon [Sun, 6 May 2012 14:56:15 +0000 (08:56 -0600)]
test: Force reply to use html2text for consistency

The output of the HTML reply test in the emacs suite can vary
depending on which HTML renderers are installed on the machine running
the tests. The renderer that is always available is emacs's builtin
html2text function. In order to get consistency, force the test to use
html2text even if other renderers are available.

8 years agoemacs: Do not pass stderr of notmuch reply to JSON parser
Michal Sojka [Tue, 1 May 2012 21:10:47 +0000 (23:10 +0200)]
emacs: Do not pass stderr of notmuch reply to JSON parser

Sometimes, notmuch reply outputs something to stderr, for example:
"Failed to verify signed part: Cannot verify multipart/signed part:
unsupported signature protocol". When this happens, replying in emacs
fails, because emacs cannot parse the error message as JSON.

This patch causes emacs to ignore stderr when reading reply from
notmuch.

8 years agoemacs: Let the user choose where to compose new mails
Thomas Jost [Fri, 4 May 2012 10:37:56 +0000 (12:37 +0200)]
emacs: Let the user choose where to compose new mails

Introduce a new defcustom notmuch-mua-compose-in that allows users to
specify where new mails are composed, either in the current window or
in a new window or frame.

Signed-off-by: Jameson Rollins <jrollins@finestructure.net>
8 years agoemacs: Correctly quote non-text/plain parts in reply
Adam Wolfe Gordon [Sat, 5 May 2012 19:30:37 +0000 (13:30 -0600)]
emacs: Correctly quote non-text/plain parts in reply

Quote non-text parts nicely by displaying them with mm-display-part
before calling message-cite-original to quote them. HTML-only emails
can now be quoted correctly. We re-use some code from notmuch-show
(notmuch-show-mm-display-part-inline), which has been moved to
notmuch-lib.el.

Mark the test for this feature as not broken.

8 years agotest: Replying to an HTML-only message in emacs
Adam Wolfe Gordon [Sat, 5 May 2012 19:24:28 +0000 (13:24 -0600)]
test: Replying to an HTML-only message in emacs

With the latest reply infrastructure, we should be able to nicely
quote HTML-only emails. But currently emacs quotes the raw HTML
instead of parsing it first. This commit adds a test for this case.

This test currently marked as broken.

8 years agodebian: add notmuch_query_set_omit_excluded to symbols file.
David Bremner [Sat, 5 May 2012 13:53:12 +0000 (10:53 -0300)]
debian: add notmuch_query_set_omit_excluded to symbols file.

This symbol is apparently part of the exclude code that was disabled
for 0.12.

8 years agodebian: update packaging for new soname libnotmuch.so.3
David Bremner [Tue, 4 Oct 2011 17:01:21 +0000 (14:01 -0300)]
debian: update packaging for new soname libnotmuch.so.3

we need
   - a new changelog stanza, because the symbols files need a new version
   - s/libnotmuch2/libnotmuch3/ everywhere
   - update symbols file, s/.so.1/.so.2/, and bump minimum versions on changed
     symbols (although the latter is just documentation)

8 years agodebian: start changelog stanza for 0.13~rc1-1
David Bremner [Sat, 5 May 2012 13:27:27 +0000 (10:27 -0300)]
debian: start changelog stanza for 0.13~rc1-1

This is mainly so that the soname bump in the debian symbols file
makes sense.

8 years agolib: Bump SO version from 2.0.0 to 3.0.0
Austin Clements [Sat, 28 Apr 2012 22:25:36 +0000 (18:25 -0400)]
lib: Bump SO version from 2.0.0 to 3.0.0

We've changed the APIs of notmuch_database_open,
notmuch_database_create, and notmuch_database_close.

Amended by db: also bump string in bindings/python/notmuch/globals.py

8 years agoNews for changes to notmuch_database_{open,create}
Austin Clements [Mon, 30 Apr 2012 16:25:38 +0000 (12:25 -0400)]
News for changes to notmuch_database_{open,create}

8 years agoruby: Update Ruby bindings for new notmuch_database_{open, create} signatures
Austin Clements [Mon, 30 Apr 2012 16:25:37 +0000 (12:25 -0400)]
ruby: Update Ruby bindings for new notmuch_database_{open, create} signatures

8 years agopython: Update Python bindings for new notmuch_database_{open, create} signatures
Austin Clements [Mon, 30 Apr 2012 16:25:36 +0000 (12:25 -0400)]
python: Update Python bindings for new notmuch_database_{open, create} signatures

8 years agogo: Update Go bindings for new notmuch_database_{open, create} signatures
Austin Clements [Mon, 30 Apr 2012 16:25:35 +0000 (12:25 -0400)]
go: Update Go bindings for new notmuch_database_{open, create} signatures

This requires changing the return types of NewDatabase and
OpenDatabase to follow the standard Go convention for returning
errors.

8 years agolib/cli: Make notmuch_database_create return a status code
Austin Clements [Mon, 30 Apr 2012 16:25:34 +0000 (12:25 -0400)]
lib/cli: Make notmuch_database_create return a status code

This is the notmuch_database_create equivalent of the previous change.

In this case, there were places where errors were not being propagated
correctly in notmuch_database_create or in calls to it.  These have
been fixed, using the new status value.

8 years agolib/cli: Make notmuch_database_open return a status code
Austin Clements [Mon, 30 Apr 2012 16:25:33 +0000 (12:25 -0400)]
lib/cli: Make notmuch_database_open return a status code

It has been a long-standing issue that notmuch_database_open doesn't
return any indication of why it failed.  This patch changes its
prototype to return a notmuch_status_t and set an out-argument to the
database itself, like other functions that return both a status and an
object.

In the interest of atomicity, this also updates every use in the CLI
so that notmuch still compiles.  Since this patch does not update the
bindings, the Python bindings test fails.

8 years agoNEWS: Insert markdown formatting commands
Tomi Ollila [Thu, 26 Apr 2012 19:52:31 +0000 (22:52 +0300)]
NEWS: Insert markdown formatting commands

To make updating the notmuchmail.org wiki 'news' section more
straightforward the content of the NEWS file has now been brought
to almost the same as the *.mdwn files in the wiki page.

The changes are basically insertion of mdwn formatting "commands".

More effort has been put into formatting the newer release entries
(0.12, 0.11 & 0.10) than older. Commit to format 0.13 entries will
be made available separately.

8 years agoNEWS: spacing changes
Tomi Ollila [Thu, 26 Apr 2012 19:52:30 +0000 (22:52 +0300)]
NEWS: spacing changes

With these whitespace changes the spacing looks generally
the same throughout the whole file.

8 years agoNEWS: untabified and added file local variables block
Tomi Ollila [Thu, 26 Apr 2012 19:52:29 +0000 (22:52 +0300)]
NEWS: untabified and added file local variables block

Changed all tabs to 8 spaces (M-x untabify over region of the
whole file).

Now this looks uniformly on all viewers (using fixed-width font)
and the observed difference between this "source" file and markdown
generated html output on browser window is smaller. In markdown to
html conversions tab and 8 spaces indents differently.

Also the "Local variables:" block added to the end of this file
attempts to ensure tabs are always expanded; whether the used editor
is Emacs or Vi.

8 years agogo: Update to the current notmuch_database_find_message API
Austin Clements [Sat, 28 Apr 2012 21:45:18 +0000 (17:45 -0400)]
go: Update to the current notmuch_database_find_message API

The signature of notmuch_database_find_message was changed in 02a30767
to report errors and the Go bindings were never updated.  This brings
the Go bindings in sync with that change and at least makes them
compile with Go r60.3, the last release before Go 1.

8 years agopython: remove a note stating wrong things about the memory management
Justus Winter [Mon, 30 Apr 2012 17:51:16 +0000 (19:51 +0200)]
python: remove a note stating wrong things about the memory management

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: document the Database.close function
Justus Winter [Mon, 30 Apr 2012 17:48:45 +0000 (19:48 +0200)]
python: document the Database.close function

Put a prominent warning into the docstring of Database.close, make the
function show up in the sphinx doc and refer to the warning in the
paragraph mentioning the context manager protocol.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: deprecate code formatting messages as text and json
Justus Winter [Mon, 30 Apr 2012 16:48:29 +0000 (18:48 +0200)]
python: deprecate code formatting messages as text and json

This code adds functionality at the python level that is unlikely to
be useful for anyone. Furthermore the python bindings strive to be a
thin wrapper around libnotmuch, so this code will be removed in
notmuch 0.14.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: cleanup the __nonzero__ implementations
Justus Winter [Mon, 30 Apr 2012 17:12:36 +0000 (19:12 +0200)]
python: cleanup the __nonzero__ implementations

Cleanup the code, reword the docstring and use the same implementation
in the Threads, Tags and Messages classes.

__nonzero__ implements truth value testing. If __nonzero__ is not
implemented, the python runtime would fall back to `len(..) > 0` thus
exhausting the iterator.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix NULL pointer tests
Justus Winter [Mon, 30 Apr 2012 16:52:35 +0000 (18:52 +0200)]
python: fix NULL pointer tests

Fix the NULL pointer tests in the destructors of all classes and
Database.create.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: update the docstrings of Filenames.{__len__,__unicode}
Justus Winter [Mon, 30 Apr 2012 16:43:02 +0000 (18:43 +0200)]
python: update the docstrings of Filenames.{__len__,__unicode}

Formerly the documentation was overly verbose. Reword the comment and
use the same for both functions.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: update the docstring of class Filenames
Justus Winter [Mon, 30 Apr 2012 16:39:06 +0000 (18:39 +0200)]
python: update the docstring of class Filenames

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix the documentation
Justus Winter [Mon, 30 Apr 2012 16:32:32 +0000 (18:32 +0200)]
python: fix the documentation

Remove the reference to Filenames.as_generator in the sphinx
documentation.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix Message.get_filenames
Justus Winter [Mon, 30 Apr 2012 16:27:15 +0000 (18:27 +0200)]
python: fix Message.get_filenames

Do not to use the removed function Filenames.as_iterator.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: remove the deprecated function Filenames.as_generator
Justus Winter [Mon, 30 Apr 2012 16:13:31 +0000 (18:13 +0200)]
python: remove the deprecated function Filenames.as_generator

Remove the function Filenames.as_generator that has been marked as
deprecated in 0.12.

The class Filenames implements the iterator protocol so you can
directly iterate over such objects instead.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoemacs: eliminate search-tag-thread in favor of just search-tag
Jameson Graef Rollins [Sat, 14 Apr 2012 18:52:54 +0000 (11:52 -0700)]
emacs: eliminate search-tag-thread in favor of just search-tag

notmuch-search-tag-thread is now completely redundant with
notmuch-search-tag so we eliminate it to simplify the interface.

8 years agoemacs: modify show tag functions to use new notmuch-tag interface
Jameson Graef Rollins [Sat, 14 Apr 2012 18:52:53 +0000 (11:52 -0700)]
emacs: modify show tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force
tag-changes to be a list, and to let notmuch-tag handle prompting the
user when required.  doc strings are also updated and cleaned up.

8 years agoemacs: modify search tag functions to use new notmuch-tag interface
Jameson Graef Rollins [Sat, 14 Apr 2012 18:52:52 +0000 (11:52 -0700)]
emacs: modify search tag functions to use new notmuch-tag interface

The main change here is to modify argument parsing so as to not force
tag-changes to be a list, and to let notmuch-tag handle prompting the
user when required.  doc strings are also updated and cleaned up.

8 years agoemacs: allow notmuch-tag to accept string inputs and prompt for tags
Jameson Graef Rollins [Sat, 14 Apr 2012 20:49:07 +0000 (13:49 -0700)]
emacs: allow notmuch-tag to accept string inputs and prompt for tags

notmuch-tag is extended to accept various formats of the tag changes.
In particular, user prompting for tag changes is now incorporated
here, so it is common for modes.

The tag binary and the notmuch-{before,after}-tag-hooks are only
called if tag changes is non-nil.

In all cases tag-changes is returned as a list.

8 years agoemacs: create notmuch-tag.el, and move appropriate functions from notmuch.el
Jameson Graef Rollins [Sat, 14 Apr 2012 18:52:50 +0000 (11:52 -0700)]
emacs: create notmuch-tag.el, and move appropriate functions from notmuch.el

Tagging functions are used in notmuch.el, notmuch-show.el, and
notmuch-message.el.  There are enough common functions for tagging
that it makes sense to put them all in their own library.

No code is modified, just moved around.

8 years agoemacs: fix archive thread/message function documentation.
Jameson Graef Rollins [Tue, 17 Jan 2012 18:43:16 +0000 (10:43 -0800)]
emacs: fix archive thread/message function documentation.

This removes an inaccuracy in the thread archiving function, and adds
a clarification to the message archiving function.

8 years agoemacs: Don't move to the next thread unless the cursor is at the end of the buffer.
David Edmondson [Tue, 31 Jan 2012 08:01:54 +0000 (08:01 +0000)]
emacs: Don't move to the next thread unless the cursor is at the end of the buffer.

When using the spacebar to scroll through a thread, hitting 'space'
when the bottom of the last message is visible should take the cursor
to the end of the buffer rather than immediately archiving the thread
and moving to the next thread.

8 years agoemacs-show: open excluded matches if no other matches
Mark Walters [Thu, 15 Mar 2012 18:28:10 +0000 (18:28 +0000)]
emacs-show: open excluded matches if no other matches

Currently emacs show does not open matching but excluded
messages. This is normally the desired behaviour but is probably not
ideal if only excluded messages match. This patch opens all the
matching (necessarily excluded) messages in this case and goes to the
first one.

8 years agoNEWS: add news item for 'config list'
Peter Wang [Sun, 29 Apr 2012 01:26:10 +0000 (11:26 +1000)]
NEWS: add news item for 'config list'

8 years agopython: strip superfluous single quote from copyright notices
Justus Winter [Sun, 29 Apr 2012 14:33:06 +0000 (16:33 +0200)]
python: strip superfluous single quote from copyright notices

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: add copyright and licensing information to setup.py
Justus Winter [Sun, 29 Apr 2012 14:30:38 +0000 (16:30 +0200)]
python: add copyright and licensing information to setup.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: stylistic and pep8 fixes in setup.py
Justus Winter [Sun, 29 Apr 2012 14:28:50 +0000 (16:28 +0200)]
python: stylistic and pep8 fixes in setup.py
Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: update the long description in setup.py
Justus Winter [Sun, 29 Apr 2012 14:26:36 +0000 (16:26 +0200)]
python: update the long description in setup.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix the test asserting that reading the version succeeded
Justus Winter [Sun, 29 Apr 2012 14:21:32 +0000 (16:21 +0200)]
python: fix the test asserting that reading the version succeeded

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: simplify a path expression in setup.py
Justus Winter [Sun, 29 Apr 2012 14:18:52 +0000 (16:18 +0200)]
python: simplify a path expression in setup.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: Remove unused import from setup.py
Justus Winter [Sun, 29 Apr 2012 14:15:41 +0000 (16:15 +0200)]
python: Remove unused import from setup.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoemacs: do not modify subject in search or show
Jameson Graef Rollins [Sun, 15 Apr 2012 02:17:52 +0000 (19:17 -0700)]
emacs: do not modify subject in search or show

A previous patch [0] replaced blank subject lines with '[No Subject]'
in search and show mode.  Apparently this was needed to circumvent
some bug in the printing code, but there was no need for it search or
show, and it is definitely not desirable, so we undo it here (a revert
is no longer feasible).  We should not be modifying strings in the
original message without good reason, or without a clear indication
that we are doing so, neither of which apply in this case.  For
further discussion see [0].

[0] id:"1327918561-16245-3-git-send-email-dme@dme.org"

8 years agoman: Document 'config list' command
Peter Wang [Sat, 14 Apr 2012 01:41:06 +0000 (11:41 +1000)]
man: Document 'config list' command

Document the 'config list' command and its output.

8 years agoconfig: Add 'config list' command
Peter Wang [Sat, 14 Apr 2012 01:41:05 +0000 (11:41 +1000)]
config: Add 'config list' command

Add a command to list all configuration items with their associated
values.

One use is as follows: a MUA may prefer to store data in a central
notmuch configuration file so that the data is accessible across
different machines, e.g. an addressbook.  The list command helps
to implement features such as tab completion on the keys.

8 years agotest: Add broken test for 'config list'
Peter Wang [Sat, 14 Apr 2012 01:41:04 +0000 (11:41 +1000)]
test: Add broken test for 'config list'

Proposed functionality.

8 years agotest: Add tests for 'config' command
Peter Wang [Sat, 14 Apr 2012 01:41:03 +0000 (11:41 +1000)]
test: Add tests for 'config' command

Start a new test script.

8 years agoconfig: Check 'config get' arity exactly
Peter Wang [Sat, 14 Apr 2012 01:41:02 +0000 (11:41 +1000)]
config: Check 'config get' arity exactly

Require that 'config get' is passed exactly one additional argument,
instead of silently ignoring extra arguments. As a side-effect, produce
more specific error messages for the 'config' command as a whole.

8 years agopython: wrap and use notmuch_database_destroy as destructor
Justus Winter [Sun, 22 Apr 2012 12:07:57 +0000 (14:07 +0200)]
python: wrap and use notmuch_database_destroy as destructor

Adapt the python bindings to the notmuch_database_close split.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoruby: Use notmuch_database_destroy instead of notmuch_database_close
Justus Winter [Sun, 22 Apr 2012 12:07:56 +0000 (14:07 +0200)]
ruby: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the ruby bindings to the notmuch_database_close split.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agogo: Use notmuch_database_destroy instead of notmuch_database_close
Justus Winter [Sun, 22 Apr 2012 12:07:55 +0000 (14:07 +0200)]
go: Use notmuch_database_destroy instead of notmuch_database_close

Adapt the go bindings to the notmuch_database_close split.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoUse notmuch_database_destroy instead of notmuch_database_close
Justus Winter [Sun, 22 Apr 2012 12:07:54 +0000 (14:07 +0200)]
Use notmuch_database_destroy instead of notmuch_database_close

Adapt notmuch-deliver to the notmuch_database_close split.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoUse notmuch_database_destroy instead of notmuch_database_close
Justus Winter [Sun, 22 Apr 2012 12:07:53 +0000 (14:07 +0200)]
Use notmuch_database_destroy instead of notmuch_database_close

Adapt the notmuch binaries source to the notmuch_database_close split.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoNEWS: Document the notmuch_database_close split
Justus Winter [Sun, 22 Apr 2012 12:07:52 +0000 (14:07 +0200)]
NEWS: Document the notmuch_database_close split

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoSplit notmuch_database_close into two functions
Justus Winter [Wed, 25 Apr 2012 13:20:16 +0000 (15:20 +0200)]
Split notmuch_database_close into two functions

Formerly notmuch_database_close closed the xapian database and
destroyed the talloc structure associated with the notmuch database
object. Split notmuch_database_close into notmuch_database_close and
notmuch_database_destroy.

This makes it possible for long running programs to close the xapian
database and thus release the lock associated with it without
destroying the data structures obtained from it.

This also makes the api more consistent since every other data
structure has a destructor function.

The comments in notmuch.h are a courtesy of Austin Clements.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoemacs: Put notmuch-hello-sections in custom group notmuch-hello
Austin Clements [Mon, 16 Apr 2012 02:57:36 +0000 (22:57 -0400)]
emacs: Put notmuch-hello-sections in custom group notmuch-hello

8 years agonew: Fix missing end_atomic in remove_filename on error
Austin Clements [Sun, 22 Apr 2012 15:50:52 +0000 (11:50 -0400)]
new: Fix missing end_atomic in remove_filename on error

Previously, if we failed to find the message by filename in
remove_filename, we would return immediately from the function without
ending its atomic block.  Now this code follows the usual goto DONE
idiom to perform cleanup.

8 years agonew: Print final fatal error message to stderr
Austin Clements [Sun, 22 Apr 2012 15:50:51 +0000 (11:50 -0400)]
new: Print final fatal error message to stderr

This was going to stdout.  I removed the newline at the beginning of
printing the fatal error message because it wouldn't make sense if you
were only looking at the stderr stream (e.g., you had redirected
stdout to /dev/null).

8 years agonew: Handle fatal errors in remove_filename and _remove_directory
Austin Clements [Sun, 22 Apr 2012 15:50:50 +0000 (11:50 -0400)]
new: Handle fatal errors in remove_filename and _remove_directory

Previously such errors were simply ignored.  Now they cause an
immediate cleanup and abort.

8 years agonew: Consistently treat fatal errors as fatal
Austin Clements [Sun, 22 Apr 2012 15:50:49 +0000 (11:50 -0400)]
new: Consistently treat fatal errors as fatal

Previously, fatal errors in add_files_recursive were not treated as
fatal by its callers (including itself!).  This makes
add_files_recursive errors consistently fatal and updates all callers
to treat them as fatal.

8 years agoemacs: Put notmuch-print-mechanism in custom group notmuch-show
Austin Clements [Mon, 16 Apr 2012 02:57:45 +0000 (22:57 -0400)]
emacs: Put notmuch-print-mechanism in custom group notmuch-show

8 years agoconfig: Fix free in 'config get' implementation.
Peter Wang [Sat, 14 Apr 2012 01:41:01 +0000 (11:41 +1000)]
config: Fix free in 'config get' implementation.

The array returned by g_key_file_get_string_list() should be freed with
g_strfreev(), not free().

8 years agoemacs: modify help message for notmuch-search-line-faces to reflect preferred "delete...
Jameson Graef Rollins [Tue, 17 Jan 2012 19:02:47 +0000 (11:02 -0800)]
emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

No functional change here.  The help message previously referred to
the "delete" tag, but "deleted" is now preferred, so hopefully this
will reduce any potential confusion.