notmuch
8 years agoNEWS: cli: manual page for notmuch configuration options
Jani Nikula [Wed, 14 Mar 2012 21:21:11 +0000 (23:21 +0200)]
NEWS: cli: manual page for notmuch configuration options

8 years agoNEWS: emacs: inline patch fake attachment file names
Jani Nikula [Wed, 14 Mar 2012 21:21:09 +0000 (23:21 +0200)]
NEWS: emacs: inline patch fake attachment file names

8 years agoNEWS: emacs: support text/calendar MIME type
Jani Nikula [Wed, 14 Mar 2012 21:21:08 +0000 (23:21 +0200)]
NEWS: emacs: support text/calendar MIME type

8 years agoNEWS: emacs: show view archiving key binding changes
Jani Nikula [Wed, 14 Mar 2012 21:21:07 +0000 (23:21 +0200)]
NEWS: emacs: show view archiving key binding changes

8 years agoNEWS: emacs: Fix MML tag quoting in replies
Jani Nikula [Wed, 14 Mar 2012 21:21:06 +0000 (23:21 +0200)]
NEWS: emacs: Fix MML tag quoting in replies

8 years agodebian: bump gmime dependency to 2.6.7 debian/0.12_rc1-1
David Bremner [Wed, 14 Mar 2012 00:40:40 +0000 (21:40 -0300)]
debian: bump gmime dependency to 2.6.7

As explained in f34613e, if using gmime 2.6, we want at least 2.6.7

8 years agoman: update SEE ALSO references in man pages
Jani Nikula [Sun, 11 Mar 2012 21:36:16 +0000 (23:36 +0200)]
man: update SEE ALSO references in man pages

Drop references to notmuch-part(1). Reference all man pages. Fix man
page section of notmuch-dump(1).

8 years agobuild: Require gmime >= 2.6.7
Thomas Jost [Tue, 21 Feb 2012 19:35:35 +0000 (20:35 +0100)]
build: Require gmime >= 2.6.7

gmime-2.6 had a bug [1] which made it impossible to tell why a signature
verification failed when the signer key was unavailable (empty "sigstatus" field
in the JSON output). Since 00b5623d the corresponding test is marked as broken
when using gmime-2.6 (2.4 is fine).

This bug has been fixed in gmime 2.6.5, which is now the minimal gmime-2.6
version required for building notmuch (gmime-2.4 is still available). As a
consequence the version check in test/crypto can be removed.

[Added by db]

Although less unambigously a bug, Gmime 2.6 prior to 2.6.7 also was
more strict about parsing, and rejected messages with initial "From "
headers.  This restriction is relaxed in [2].  For reasons explained in [3],
we want to keep this more relaxed parsing for now.

[1] https://bugzilla.gnome.org/show_bug.cgi?id=668085

[2] http://git.gnome.org/browse/gmime/commit/?id=d311f576baf750476e06e9a1367a2dc1793ea7eb

[3] id:"1331385931-1610-1-git-send-email-david@tethera.net"

8 years agoFix configure script to properly detect gmime-2.6 if available.
Jameson Graef Rollins [Thu, 8 Mar 2012 16:45:01 +0000 (08:45 -0800)]
Fix configure script to properly detect gmime-2.6 if available.

Previously, the configure script would appear to detect gmime-2.6 if
present.  However, the binaries would end up being compiled against
gmime-2.4.  The addition of a break fixes things so that now gmime-2.6
will be used if available, falling back to gmime-2.4.

8 years agoHandle errors in mime_node_open
Austin Clements [Tue, 6 Mar 2012 18:26:57 +0000 (18:26 +0000)]
Handle errors in mime_node_open

8 years agoemacs: fix MML quoting in replies
Jani Nikula [Sun, 4 Mar 2012 08:25:38 +0000 (10:25 +0200)]
emacs: fix MML quoting in replies

The reply MML quoting added in commit ae438cc unintentionally MML
quotes also the signature/encryption MML tags added via
message-setup-hook, causing the reply not to be signed/encrypted.

MML quote just the original message in the temp buffer before
inserting it to the message buffer, to not interfere with message mode
hooks or message construction in general.

See [1] and [2] for bug reports.

Thanks to Tim Bielawa <tbielawa@redhat.com> for testing.

[1] id:"87hay78x6l.fsf@wyzanski.jamesvasile.com"
[2] id:"1330812262-28272-1-git-send-email-tbielawa@redhat.com".

Signed-off-by: Jani Nikula <jani@nikula.org>
8 years agoActually close the xapian database in notmuch_database_close
Justus Winter [Fri, 2 Mar 2012 14:58:39 +0000 (15:58 +0100)]
Actually close the xapian database in notmuch_database_close

Formerly the xapian database object was deleted and closed in its
destructor once the object was garbage collected. Explicitly call
close() so that the database and the associated lock is released
immediately.

The comment is a courtesy of Austin Clements.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agodebian: Bump standards version
David Bremner [Sat, 3 Mar 2012 13:40:18 +0000 (09:40 -0400)]
debian: Bump standards version

No actual changes are needed.

8 years agodebian: update .gitignore
David Bremner [Sat, 3 Mar 2012 13:38:45 +0000 (09:38 -0400)]
debian: update .gitignore

Ignore individual binary package directories.

8 years agodebian: add notmuch_query_add_tag_exclude to exported symbols
David Bremner [Sat, 3 Mar 2012 13:19:44 +0000 (09:19 -0400)]
debian: add notmuch_query_add_tag_exclude to exported symbols

This symbol is added in 0.12, although we are "stealthing" the feature
overall.

8 years agoman: remove search.exclude_tags from notmuch-config.1 for 0.12
Mark Walters [Wed, 29 Feb 2012 18:13:07 +0000 (18:13 +0000)]
man: remove search.exclude_tags from notmuch-config.1 for 0.12

8 years agoNEWS: revert NEWS item for exclude tags for 0.12
Mark Walters [Wed, 29 Feb 2012 18:13:06 +0000 (18:13 +0000)]
NEWS: revert NEWS item for exclude tags for 0.12

8 years agoconfig: disable addition of exclude tags for 0.12
Mark Walters [Wed, 29 Feb 2012 18:13:05 +0000 (18:13 +0000)]
config: disable addition of exclude tags for 0.12

This disables the addition of search_exclude_tags in notmuch-setup and
notmuch-config.

8 years agoSpelling fix
Tomi Ollila [Thu, 1 Mar 2012 13:34:06 +0000 (15:34 +0200)]
Spelling fix

Retreive is spelled as r e t r i e v e .

8 years agoemacs: retain show buffer state after retrieving gpg key
Tomi Ollila [Thu, 1 Mar 2012 13:34:05 +0000 (15:34 +0200)]
emacs: retain show buffer state after retrieving gpg key

After retrieving gpg key retain show buffer state like in
all other operations (i.e. no other calls to notmuch-show-refresh-view
provides optional reset-state argument).
Emacs MUA keeps current message under cursor instead of going first
open message(possibly marking it read).

8 years agoNEWS: add entry for `notmuch-show-stash-mlarchive-link{,-and-go}'
Pieter Praet [Thu, 1 Mar 2012 21:44:30 +0000 (22:44 +0100)]
NEWS: add entry for `notmuch-show-stash-mlarchive-link{,-and-go}'

8 years agoadd minimal changelog stanza for 0.12~rc1
David Bremner [Thu, 1 Mar 2012 11:52:05 +0000 (07:52 -0400)]
add minimal changelog stanza for 0.12~rc1

8 years agobump version to 0.12~rc1
David Bremner [Thu, 1 Mar 2012 11:47:21 +0000 (07:47 -0400)]
bump version to 0.12~rc1

As usual, only `version' is edited by hand. The rest of the changes I
blame on the machine.

8 years agoemacs: Clarify description of thread manipulating functions
Michal Sojka [Tue, 21 Feb 2012 09:15:08 +0000 (10:15 +0100)]
emacs: Clarify description of thread manipulating functions

It is not clear whether the term "thread" refers to the thread in the
database or to the thread currently shown in a buffer. Those two
meanings may refer to different sets of messages, e.g. when a new email
is added to the database while the buffer shows the state before the new
email arrived.

This patch replaces the term thread with the term current buffer, which
is hopefully less ambiguous.

8 years agotest: Remove 'broken' flag from encoding test
Michal Sojka [Fri, 24 Feb 2012 07:36:23 +0000 (08:36 +0100)]
test: Remove 'broken' flag from encoding test

8 years agoConvert non-UTF-8 parts to UTF-8 before indexing them
Michal Sojka [Fri, 24 Feb 2012 07:36:22 +0000 (08:36 +0100)]
Convert non-UTF-8 parts to UTF-8 before indexing them

This fixes a bug that didn't allow to search for non-ASCII words such
parts. The code here was copied from show_text_part_content(), because
the show command already does the needed conversion when showing the
message.

8 years agotest: Add test for searching of uncommonly encoded messages
Michal Sojka [Fri, 24 Feb 2012 00:33:15 +0000 (01:33 +0100)]
test: Add test for searching of uncommonly encoded messages

Emails that are encoded differently than as ASCII or UTF-8 are not
indexed properly by notmuch. It is not possible to search for non-ASCII
words within those messages.

8 years agodoc: minor corrections in notmuch-config.1
Pieter Praet [Tue, 28 Feb 2012 18:42:03 +0000 (19:42 +0100)]
doc: minor corrections in notmuch-config.1

* man/man1/notmuch-config.1

  - SYNOPSIS:
    Remove spaces in 'section.item' arg, and indicate that
    `notmuch config set' accepts multiple value args.

  - DESCRIPTION:
    Correct config option to exclude tags from search results.
    ('search.exclude_tags' instead of 'search.exclude')

Also see commit bb8ab4c8.

8 years agoNews for Make buttons for attachments allow viewing as well as saving
Mark Walters [Wed, 29 Feb 2012 09:31:26 +0000 (09:31 +0000)]
News for Make buttons for attachments allow viewing as well as saving

On Sat, 21 Jan 2012 09:09:58 -0400, David Bremner <david@tethera.net> wrote:
> On Fri, 20 Jan 2012 09:44:06 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> > Define a keymap for attachment buttons to allow multiple actions.
> > Define 3 possible actions:
> >     save attachment: exactly as currently,
> >     view attachment: uses mailcap entry,
> >     view attachment with user chosen program
>
> pushed.

Here is a News patch for this feature.

Best wishes

Mark

From fde33258850a438f1810e4158c946b3cf185b5e8 Mon Sep 17 00:00:00 2001
From: Mark Walters <markwalters1009@gmail.com>
Date: Wed, 29 Feb 2012 09:26:17 +0000
Subject: [PATCH] News item for allowing attachment buttons to view as well as save.

8 years agoman: add references to maildir flag synchronization
Jani Nikula [Sat, 25 Feb 2012 22:57:23 +0000 (00:57 +0200)]
man: add references to maildir flag synchronization

notmuch new, restore, and tag commands support maildir flag
synchronization with notmuch tags. Reference the notmuch-config(1) man
page about it in the relevant man pages.

8 years agoman: document the notmuch configuration settings in notmuch-config(1)
Jani Nikula [Sat, 25 Feb 2012 22:23:41 +0000 (00:23 +0200)]
man: document the notmuch configuration settings in notmuch-config(1)

At the risk of duplication between the man page and the configuration
file generated by default, document the notmuch configuration options
in the notmuch config man page.

Existing users of notmuch should not be expected to re-generate their
config file in order to get access to the documentation for new
configuration options.

Include some minor fixes and cleanups while at it.

8 years agoemacs: Fix out of date comment
Austin Clements [Sat, 25 Feb 2012 14:50:26 +0000 (09:50 -0500)]
emacs: Fix out of date comment

The behavior of the header line in show-mode changed from showing the
subject of the first open message to showing the subject of the first
message in 4d77f18b.  Update a comment to reflect this.

8 years agoDocument the JSON schemata used by show and search
Austin Clements [Mon, 20 Feb 2012 00:26:23 +0000 (19:26 -0500)]
Document the JSON schemata used by show and search

8 years agoNEWS: sync 'new.ignore' entry with its comment in notmuch-config.c
Pieter Praet [Sun, 19 Feb 2012 20:47:52 +0000 (21:47 +0100)]
NEWS: sync 'new.ignore' entry with its comment in notmuch-config.c

See previous commit.

8 years agocli: update 'new.ignore' config file comment wrt file/directory matching
Pieter Praet [Sun, 19 Feb 2012 20:47:51 +0000 (21:47 +0100)]
cli: update 'new.ignore' config file comment wrt file/directory matching

8 years agoBuild-Depend on libgmime-2.6-dev | libgmime2.4-dev
Daniel Kahn Gillmor [Thu, 9 Feb 2012 23:20:20 +0000 (18:20 -0500)]
Build-Depend on libgmime-2.6-dev | libgmime2.4-dev

libgmime-2.6-dev entered debian unstable today.  If 2.6 is available,
notmuch should build against 2.6 instead of 2.4, as 2.6 is the current
upstream stable version of libgmime.

8 years agoNews for retaining state when refreshing notmuch show
Austin Clements [Tue, 21 Feb 2012 15:42:33 +0000 (10:42 -0500)]
News for retaining state when refreshing notmuch show

8 years agoemacs: Reverse the meaning of notmuch-show-refresh-view's argument
Austin Clements [Tue, 21 Feb 2012 15:42:32 +0000 (10:42 -0500)]
emacs: Reverse the meaning of notmuch-show-refresh-view's argument

Consensus seems to be that people prefer that refreshing show buffers
retains state by default, rather than resetting it by default.  This
turns out to be the case in the code, as well.  In fact, there's even
a test for this that's been marked broken for several months, which
this patch finally gets to mark as fixed.

8 years agoemacs: When refreshing a show buffer, only mark read when resetting state
Austin Clements [Tue, 21 Feb 2012 15:42:31 +0000 (10:42 -0500)]
emacs: When refreshing a show buffer, only mark read when resetting state

If we retain state while refreshing a show buffer, it should not mark
any messages read since it's not a navigation operation (it especially
shouldn't mark the first message matching the query read, which is
what it did previously).  If the user or caller requests that refresh
reset the state of the buffer, then we consider that a navigation
operation, so we do mark the message under point after the refresh
read.

This is implemented by moving responsibility for initial positioning
and read-marking out of notmuch-show-worker and into its caller.
Since notmuch-show-worker is now exclusively about building the show
buffer, we rename it to notmuch-show-build-buffer.

8 years agoemacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'
Pieter Praet [Sun, 19 Feb 2012 20:50:27 +0000 (21:50 +0100)]
emacs: add `notmuch-show-stash-mlarchive-link{, -and-go}'

* emacs/notmuch-show.el

  (notmuch-show-stash-mlarchive-link-alist):
    New defcustom of type `alist' (key = name, value = URI),
    containing Mailing List Archive URI's for searching by Message-Id.

  (notmuch-show-stash-mlarchive-link-default):
    New defcustom, default MLA to use when `notmuch-show-stash-mlarchive-link'
    received no user input whatsoever.  Available choices are generated using
    the contents of `notmuch-show-stash-mlarchive-link-alist'.

  (notmuch-show-stash-map):
    Added keybinds "l" and "L" for `notmuch-show-stash-mlarchive-link'
    respectively `notmuch-show-stash-mlarchive-link-and-go'.

  (notmuch-show-stash-mlarchive-link):
    New function, stashes a URI pointing to the current message at one
    of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'.
    Prompts user with `completing-read' if not provided with an MLA key.

  (notmuch-show-stash-mlarchive-link-and-go):
    New function, uses `notmuch-show-stash-mlarchive-link' to
    stash a URI, and then visits it using the browser configured
    in `browse-url-browser-function'.

Based on original work [1] by David Edmondson <dme@dme.org>.

[1] id:"1327397873-20596-1-git-send-email-dme@dme.org"

8 years agotest: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List...
Pieter Praet [Sun, 19 Feb 2012 20:50:26 +0000 (21:50 +0100)]
test: emacs: expand subtest "Stashing in notmuch-show" wrt stashing Mailing List Archive URIs

`notmuch-show-stash-mlarchive-link' stashes a URI pointing to the current message
at one of the MLAs configured in `notmuch-show-stash-mlarchive-link-alist'.

Marked as "broken": fixed in next commit.

8 years agoemacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix
Pieter Praet [Sun, 19 Feb 2012 20:50:25 +0000 (21:50 +0100)]
emacs: `notmuch-show-get-message-id': optionally return Message-Id sans prefix

* emacs/notmuch-show.el

  (notmuch-show-get-message-id):
    Add optional arg BARE.  When non-nil, return a Message-Id without
    quotes and prefix, thus obviating the need to strip them off again
    in various places.

  (notmuch-show-stash-message-id-stripped):
    Update wrt changes in `notmuch-show-get-message-id'.

8 years agoNEWS: add entry for the improved unicode handling in the python bindings
Justus Winter [Wed, 22 Feb 2012 19:33:31 +0000 (20:33 +0100)]
NEWS: add entry for the improved unicode handling in the python bindings

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoNEWS: add entry for python 3.2 compatibility
Justus Winter [Wed, 22 Feb 2012 19:33:30 +0000 (20:33 +0100)]
NEWS: add entry for python 3.2 compatibility

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoemacs: support text/calendar mime type
Jani Nikula [Thu, 9 Feb 2012 14:46:03 +0000 (14:46 +0000)]
emacs: support text/calendar mime type

Replace text/x-vcalendar with text/calendar, while maintaining support
and backwards compatibility for text/x-vcalendar.

Code by David Edmondson <dme@dme.org>

8 years agotest: replace occurrences of $PWD with vars that are more stable
Pieter Praet [Wed, 1 Feb 2012 20:37:21 +0000 (21:37 +0100)]
test: replace occurrences of $PWD with vars that are more stable

Thanks to Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
for pointing this out:  id:"87d39ymyb4.fsf@gmail.com"

8 years agopython: split the documentation
Justus Winter [Fri, 24 Feb 2012 00:34:15 +0000 (01:34 +0100)]
python: split the documentation

Move each classes documentation into its own file and thus into its
own page in the generated documentation.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move the notmuch module section to notes.rst
Justus Winter [Fri, 24 Feb 2012 00:30:04 +0000 (01:30 +0100)]
python: move the notmuch module section to notes.rst

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move the usage example to quickstart.rst
Justus Winter [Fri, 24 Feb 2012 00:18:54 +0000 (01:18 +0100)]
python: move the usage example to quickstart.rst

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: strip module prefix in the sphinx documentation
Justus Winter [Thu, 23 Feb 2012 23:38:47 +0000 (00:38 +0100)]
python: strip module prefix in the sphinx documentation

Remove the notmuch prefix from classes in the documentation. This
change makes the table of contents look much nicer.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: mention the exception class refactoring in the docs
Justus Winter [Wed, 22 Feb 2012 23:14:59 +0000 (00:14 +0100)]
python: mention the exception class refactoring in the docs

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move the exception classes into error.py
Justus Winter [Wed, 22 Feb 2012 23:11:22 +0000 (00:11 +0100)]
python: move the exception classes into error.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: rename filename.py into filenames.py
Justus Winter [Wed, 22 Feb 2012 21:44:35 +0000 (22:44 +0100)]
python: rename filename.py into filenames.py

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move Threads class into its own file
Justus Winter [Wed, 22 Feb 2012 21:39:52 +0000 (22:39 +0100)]
python: move Threads class into its own file

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move Messages class into its own file
Justus Winter [Wed, 22 Feb 2012 21:34:40 +0000 (22:34 +0100)]
python: move Messages class into its own file

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: refactor the python bindings
Justus Winter [Wed, 22 Feb 2012 20:55:59 +0000 (21:55 +0100)]
python: refactor the python bindings

Move the Directory class into its own file, merge the two Filenames
classes into one, deprecate Filenames.as_iterator, update the
documentation accordingly.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: work around libnotmuch calling exit(3) in Database.find_message_by_filename
Justus Winter [Wed, 22 Feb 2012 20:14:13 +0000 (21:14 +0100)]
python: work around libnotmuch calling exit(3) in Database.find_message_by_filename

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: improve the docstring of Database.find_message_by_filename
Justus Winter [Wed, 22 Feb 2012 20:07:18 +0000 (21:07 +0100)]
python: improve the docstring of Database.find_message_by_filename

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: work around libnotmuch calling exit(3) in Database.get_directory
Justus Winter [Wed, 22 Feb 2012 19:58:44 +0000 (20:58 +0100)]
python: work around libnotmuch calling exit(3) in Database.get_directory

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: Improve the docstring of Database.get_directory
Justus Winter [Wed, 22 Feb 2012 19:46:42 +0000 (20:46 +0100)]
python: Improve the docstring of Database.get_directory
Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: avoid using a magic value for database mode in Database.__init__
Justus Winter [Wed, 22 Feb 2012 20:01:24 +0000 (21:01 +0100)]
python: avoid using a magic value for database mode in Database.__init__

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agotest: always report missing prereqs, independent of `--verbose' option
Pieter Praet [Wed, 18 Jan 2012 12:19:41 +0000 (13:19 +0100)]
test: always report missing prereqs, independent of `--verbose' option

When tests are skipped due to missing prereqs, those prereqs are only
displayed when running with the `--verbose' option.  This is essential
information when troubleshooting, so always send to stdout.

8 years agoemacs: Fix out-of-date declare-function
Austin Clements [Sun, 19 Feb 2012 18:02:40 +0000 (13:02 -0500)]
emacs: Fix out-of-date declare-function

The names of the arguments to notmuch-show-refresh-view had gotten out
of sync between the declare-function and the real thing.

8 years agoPrevent segmentation fault in notmuch_database_close
Justus Winter [Sat, 18 Feb 2012 23:56:57 +0000 (00:56 +0100)]
Prevent segmentation fault in notmuch_database_close

Previously opening a notmuch database in read write mode that has been
locked resulted in the notmuch_database_open function executing
notmuch_database_close as a cleanup function. notmuch_database_close
failed to check whether the xapian database has in fact been created.

Add a check whether the xapian database object has actually been
created before trying to call its flush method.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix the type nonsense of the first parameter of class Directory
Justus Winter [Tue, 21 Feb 2012 00:06:15 +0000 (01:06 +0100)]
python: fix the type nonsense of the first parameter of class Directory

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: allow an empty path as parameter to Database.get_directory
Justus Winter [Mon, 20 Feb 2012 23:56:07 +0000 (00:56 +0100)]
python: allow an empty path as parameter to Database.get_directory

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: remove :returns: keywords from functions returning nothing
Justus Winter [Mon, 20 Feb 2012 23:15:59 +0000 (00:15 +0100)]
python: remove :returns: keywords from functions returning nothing

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: rework Directory.set_mtime
Justus Winter [Mon, 20 Feb 2012 23:13:20 +0000 (00:13 +0100)]
python: rework Directory.set_mtime

Fix the indentation within the docstring, remove useless remarks, do
some trivial refactoring.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: harmonize the sphinx keyword for exceptions
Justus Winter [Mon, 20 Feb 2012 23:01:23 +0000 (00:01 +0100)]
python: harmonize the sphinx keyword for exceptions

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: refactor the error handling machinery
Justus Winter [Mon, 20 Feb 2012 22:49:07 +0000 (23:49 +0100)]
python: refactor the error handling machinery

Raise specific error classes instead of a generic NotmuchError with an
magic status value (e.g. NotmuchError(STATUS.NULL_POINTER) ->
NullPointerError()), update the documentation accordingly.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: fix the projects name and update years of the copyright notice in the sphinx...
Justus Winter [Mon, 20 Feb 2012 20:48:35 +0000 (21:48 +0100)]
python: fix the projects name and update years of the copyright notice in the sphinx docs

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: more error handling fixes
Justus Winter [Sat, 18 Feb 2012 23:36:15 +0000 (00:36 +0100)]
python: more error handling fixes

This is a follow up commit to 221c7e0b38177f5f1dbf0561580c15e8aaa49004
fixing more NULL pointer checks.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: remove trailing whitespace within the documentation source files
Justus Winter [Sat, 18 Feb 2012 00:41:23 +0000 (01:41 +0100)]
python: remove trailing whitespace within the documentation source files

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: improve Query.count_messages docstring
Justus Winter [Sat, 18 Feb 2012 00:38:19 +0000 (01:38 +0100)]
python: improve Query.count_messages docstring

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: wrap notmuch_query_count_threads as Query.count_threads
Justus Winter [Sat, 18 Feb 2012 00:32:21 +0000 (01:32 +0100)]
python: wrap notmuch_query_count_threads as Query.count_threads

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: refactor Query class
Justus Winter [Sat, 18 Feb 2012 00:13:06 +0000 (01:13 +0100)]
python: refactor Query class

Put each libnotmuch function reference right in front of the
corresponding python wrapper.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: move Query class to its own file
Justus Winter [Sat, 18 Feb 2012 00:10:45 +0000 (01:10 +0100)]
python: move Query class to its own file

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: remove unused but imported symbol
Justus Winter [Sat, 18 Feb 2012 00:01:33 +0000 (01:01 +0100)]
python: remove unused but imported symbol

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: remove unused but imported symbol
Justus Winter [Fri, 17 Feb 2012 23:57:59 +0000 (00:57 +0100)]
python: remove unused but imported symbol

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoNEWS: add news section for new.ignore
Tomi Ollila [Wed, 15 Feb 2012 09:17:32 +0000 (11:17 +0200)]
NEWS: add news section for new.ignore

Added NEWS section 'Mail store folder/file ignore'.

8 years agoadd support for user-specified files & directories to ignore
Tomi Ollila [Wed, 15 Feb 2012 09:17:31 +0000 (11:17 +0200)]
add support for user-specified files & directories to ignore

A new configuration key 'new.ignore' is used to determine which
files and directories user wants not to be scanned as new mails.

Mark the corresponding test as no longer broken.
This work merges my previous attempts and Andreas Amann's work
in id:"ylp7hi23mw8.fsf@tyndall.ie"

8 years agotest: add tests wrt ignoring user-specified files and directories
Tomi Ollila [Wed, 15 Feb 2012 09:17:30 +0000 (11:17 +0200)]
test: add tests wrt ignoring user-specified files and directories

Files and directories which are specified in 'new.ignore' in the
config file shouldn't be indexed nor reported by `notmuch new'.

This is basically Pieter's work with Austin's comments addressed.

8 years agoemacs: Fix display of highlighted line in notmuch-search
Michal Sojka [Tue, 14 Feb 2012 17:09:47 +0000 (18:09 +0100)]
emacs: Fix display of highlighted line in notmuch-search

When notmuch-search-line-faces is used to set background color in search
results, the highlight of the current line is not always displayed
correctly. This patch fixes that by increasing the priority property of
the highlight overlay.

8 years agopython: implement the context manager protocol for database objects
Justus Winter [Wed, 15 Feb 2012 21:41:16 +0000 (22:41 +0100)]
python: implement the context manager protocol for database objects

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agopython: provide a Database.close function
Justus Winter [Wed, 15 Feb 2012 21:25:13 +0000 (22:25 +0100)]
python: provide a Database.close function

Rename Database.__del__ to Database.close, move it just below the open
function and call close() in a newly created destructor just below the
constructor.

Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
8 years agoFree the results of scandir()
Ethan Glasser-Camp [Tue, 7 Feb 2012 10:05:03 +0000 (05:05 -0500)]
Free the results of scandir()

scandir() returns "strings allocated via malloc(3)" which are then
"collected in array namelist which is allocated via
malloc(3)". Currently we just free the array namelist. Instead, free
all the entries of namelist, and then free namelist.

entry only points to elements of namelist, so we don't free it
separately.

8 years agoemacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively
Dmitry Kurochkin [Mon, 13 Feb 2012 11:09:07 +0000 (15:09 +0400)]
emacs: allow to set RETAIN-STATE for `notmuch-show-refresh-view' interactively

The notmuch-show view refresh function (`notmuch-show-refresh-view',
bound to "=") accepts an optional RETAIN-STATE argument.  The patch
allows to set this argument interactively by using "C-u =".

8 years agoemacs: cleanup and simplify `notmuch-show-archive-thread' and related functions
Dmitry Kurochkin [Wed, 8 Feb 2012 16:48:51 +0000 (20:48 +0400)]
emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

Recent changes in notmuch-show tagging introduced some code
duplication.  The patch cleanups and simplifies
`notmuch-show-archive-thread' function by using
`notmuch-show-tag-all', no longer used function are removed.  After
the change, `notmuch-show-archive-thread' function becomes symmetric
with `notmuch-show-archive-message'.

A side effect of these changes is that `notmuch-show-archive-thread'
no longer calls "notmuch tag" for each message in the thread.

8 years agoemacs: A prefix argument to `notmuch-show' should invert the matching message behaviour.
David Edmondson [Wed, 8 Feb 2012 08:02:19 +0000 (08:02 +0000)]
emacs: A prefix argument to `notmuch-show' should invert the matching message behaviour.

Allow the user to open a thread with inverted
`notmuch-show-only-matching-messages' behaviour using a prefix
argument.

8 years agoemacs: Add `notmuch-show-only-matching-messages'.
David Edmondson [Wed, 8 Feb 2012 08:02:18 +0000 (08:02 +0000)]
emacs: Add `notmuch-show-only-matching-messages'.

Allow the user to choose that only matching messages are shown by
default.

8 years agoemacs: Check that the parent buffer is alive before using it.
David Edmondson [Wed, 8 Feb 2012 08:02:17 +0000 (08:02 +0000)]
emacs: Check that the parent buffer is alive before using it.

8 years agoemacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.
David Edmondson [Wed, 8 Feb 2012 08:02:16 +0000 (08:02 +0000)]
emacs: Optionally retain the state of the buffer during `notmuch-show-refresh-view'.

With an argument, record and reply the state of the buffer during
`notmuch-show-refresh-view'.

In this context, "state" is defined as:
 - the open/closed state of each message,
 - the current message.

Traditional use of refresh with the = key does not retain the
state. The recently introduced toggle commands ($, !, < and >) do
retain the state.

8 years agoemacs: Add a binding (t) to toggle the truncation of long lines.
David Edmondson [Wed, 8 Feb 2012 08:02:15 +0000 (08:02 +0000)]
emacs: Add a binding (t) to toggle the truncation of long lines.

8 years agoemacs: Allow the indentation of content to be toggled.
David Edmondson [Wed, 8 Feb 2012 08:02:14 +0000 (08:02 +0000)]
emacs: Allow the indentation of content to be toggled.

Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with '<'.

Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.

8 years agoemacs: Allow `notmuch-show-mode' to display only matching messages.
David Edmondson [Wed, 8 Feb 2012 08:02:12 +0000 (08:02 +0000)]
emacs: Allow `notmuch-show-mode' to display only matching messages.

The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.

8 years agoemacs: Rework crypto switch toggle.
David Edmondson [Wed, 8 Feb 2012 08:02:10 +0000 (08:02 +0000)]
emacs: Rework crypto switch toggle.

Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.

To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour in
future patches.)

Add a binding ('$') to toggle crypto processing of the current buffer
and remove the prefix argument approach that achieves a similar
result.

8 years agoemacs: Ensure that gnupg output goes at the end of the buffer.
David Edmondson [Tue, 7 Feb 2012 17:26:11 +0000 (17:26 +0000)]
emacs: Ensure that gnupg output goes at the end of the buffer.

When showing the user some details of gnupg output, ensure that those
details are shown at the end of the gnupg status buffer
("*notmuch-crypto-gpg-out*"), otherwise it can end up mixed up with
earlier output.

8 years agocli: reach previously unreachable cleanup code in "notmuch show"
Jani Nikula [Mon, 6 Feb 2012 19:57:23 +0000 (21:57 +0200)]
cli: reach previously unreachable cleanup code in "notmuch show"

The last lines of notmuch_show_command() function were
unreachable. Fix it by using a variable for return value.

Signed-off-by: Jani Nikula <jani@nikula.org>
8 years agocli: convert "notmuch show" to use the new argument parser
Jani Nikula [Mon, 6 Feb 2012 19:57:22 +0000 (21:57 +0200)]
cli: convert "notmuch show" to use the new argument parser

Use the new notmuch argument parser to handle arguments in "notmuch
show". There are three minor functional changes:

1) Also set params.raw = TRUE when defaulting to raw format when part
   is requested but format is not specified. This was a bug, and
   --part=0 without --format=raw did not work previously.

2) Set params.decrypt = FALSE if crypto context creation fails.

3) Only use the parameters for the last --format if specified multiple
   times. Previously this could have resulted in a non-working mixture
   of parameters.

Signed-off-by: Jani Nikula <jani@nikula.org>
8 years agocli: use notmuch_bool_t for boolean fields in notmuch_show_params_t
Jani Nikula [Mon, 6 Feb 2012 19:57:21 +0000 (21:57 +0200)]
cli: use notmuch_bool_t for boolean fields in notmuch_show_params_t

Use notmuch_bool_t instead of int for entire_thread, raw, and decrypt
boolean fields in notmuch_show_params_t. No functional changes.

Signed-off-by: Jani Nikula <jani@nikula.org>